Skip to content

Commit d96488c

Browse files
[Python] Declare various modules as private (#884)
* Declare various modules private - `telemetry` - `jsonrpc` - `sdk_protocol_version` * Add back in trailing whitespace --------- Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
1 parent 2bfbb47 commit d96488c

File tree

10 files changed

+14
-13
lines changed

10 files changed

+14
-13
lines changed

nodejs/scripts/update-protocol-version.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Reads from sdk-protocol-version.json and generates:
99
* - nodejs/src/sdkProtocolVersion.ts
1010
* - go/sdk_protocol_version.go
11-
* - python/copilot/sdk_protocol_version.py
11+
* - python/copilot/_sdk_protocol_version.py
1212
* - dotnet/src/SdkProtocolVersion.cs
1313
*
1414
* Run this script whenever the protocol version changes.
@@ -89,8 +89,8 @@ def get_sdk_protocol_version() -> int:
8989
"""
9090
return SDK_PROTOCOL_VERSION
9191
`;
92-
fs.writeFileSync(path.join(rootDir, "python", "copilot", "sdk_protocol_version.py"), pythonCode);
93-
console.log(" ✓ python/copilot/sdk_protocol_version.py");
92+
fs.writeFileSync(path.join(rootDir, "python", "copilot", "_sdk_protocol_version.py"), pythonCode);
93+
console.log(" ✓ python/copilot/_sdk_protocol_version.py");
9494

9595
// Generate C#
9696
const csharpCode = `// Code generated by update-protocol-version.ts. DO NOT EDIT.

python/copilot/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
from pathlib import Path
2626
from typing import Any, cast, overload
2727

28+
from ._jsonrpc import JsonRpcClient, ProcessExitedError
29+
from ._sdk_protocol_version import get_sdk_protocol_version
30+
from ._telemetry import get_trace_context, trace_context
2831
from .generated.rpc import ServerRpc
2932
from .generated.session_events import PermissionRequest, session_event_from_dict
30-
from .jsonrpc import JsonRpcClient, ProcessExitedError
31-
from .sdk_protocol_version import get_sdk_protocol_version
3233
from .session import CopilotSession
33-
from .telemetry import get_trace_context, trace_context
3434
from .types import (
3535
ConnectionState,
3636
CustomAgentConfig,

python/copilot/generated/rpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from typing import TYPE_CHECKING
77

88
if TYPE_CHECKING:
9-
from ..jsonrpc import JsonRpcClient
9+
from .._jsonrpc import JsonRpcClient
1010

1111

1212
from dataclasses import dataclass

python/copilot/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
from collections.abc import Callable
1212
from typing import Any, Literal, cast
1313

14+
from ._jsonrpc import JsonRpcError, ProcessExitedError
15+
from ._telemetry import get_trace_context, trace_context
1416
from .generated.rpc import (
1517
Kind,
1618
Level,
@@ -23,8 +25,6 @@
2325
SessionToolsHandlePendingToolCallParams,
2426
)
2527
from .generated.session_events import SessionEvent, SessionEventType, session_event_from_dict
26-
from .jsonrpc import JsonRpcError, ProcessExitedError
27-
from .telemetry import get_trace_context, trace_context
2828
from .types import (
2929
Attachment,
3030
PermissionRequest,

python/test_jsonrpc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
import pytest
1515

16-
from copilot.jsonrpc import JsonRpcClient
16+
from copilot._jsonrpc import JsonRpcClient
1717

1818

1919
class MockProcess:

python/test_telemetry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from unittest.mock import patch
66

7-
from copilot.telemetry import get_trace_context, trace_context
7+
from copilot._telemetry import get_trace_context, trace_context
88
from copilot.types import SubprocessConfig, TelemetryConfig
99

1010

scripts/codegen/python.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ import fs from "fs/promises";
1010
import type { JSONSchema7 } from "json-schema";
1111
import { FetchingJSONSchemaStore, InputData, JSONSchemaInput, quicktype } from "quicktype-core";
1212
import {
13-
getSessionEventsSchemaPath,
1413
getApiSchemaPath,
14+
getSessionEventsSchemaPath,
15+
isRpcMethod,
1516
postProcessSchema,
1617
writeGeneratedFile,
1718
isRpcMethod,
@@ -242,7 +243,7 @@ Generated from: api.schema.json
242243
from typing import TYPE_CHECKING
243244
244245
if TYPE_CHECKING:
245-
from ..jsonrpc import JsonRpcClient
246+
from .._jsonrpc import JsonRpcClient
246247
247248
`);
248249
lines.push(typesCode);

0 commit comments

Comments
 (0)