Rust SDK API review fixes (#1367)

Author: SteveSandersonMS

docs/features/remote-sessions.md

@@ -100,7 +100,7 @@ session.On((SessionEvent e) =>
 use github_copilot_sdk::{Client, ClientOptions, PermissionRequestResult, SessionConfig};
 
 let client = Client::start(
-    ClientOptions::new().with_remote(true)
+    ClientOptions::new().with_enable_remote_sessions(true)
 ).await?;
 let session = client.create_session(
     SessionConfig::new("/path/to/github-repo")

dotnet/src/Client.cs

@@ -595,7 +595,7 @@ public async Task<CopilotSession> CreateSessionAsync(SessionConfig config, Cance
                 config.ExcludedTools,
                 config.Provider,
                 config.EnableSessionTelemetry,
-                (bool?)true,
+                config.OnPermissionRequest != null ? true : null,
                 config.OnUserInputRequest != null ? true : null,
                 config.OnExitPlanModeRequest != null ? true : null,
                 config.OnAutoModeSwitchRequest != null ? true : null,
@@ -754,7 +754,7 @@ public async Task<CopilotSession> ResumeSessionAsync(string sessionId, ResumeSes
                 config.ExcludedTools,
                 config.Provider,
                 config.EnableSessionTelemetry,
-                (bool?)true,
+                config.OnPermissionRequest != null ? true : null,
                 config.OnUserInputRequest != null ? true : null,
                 config.OnExitPlanModeRequest != null ? true : null,
                 config.OnAutoModeSwitchRequest != null ? true : null,

go/client.go

@@ -666,7 +666,9 @@ func (c *Client) CreateSession(ctx context.Context, config *SessionConfig) (*Ses
 		config.Hooks.OnErrorOccurred != nil) {
 		req.Hooks = Bool(true)
 	}
-	req.RequestPermission = Bool(true)
+	if config.OnPermissionRequest != nil {
+		req.RequestPermission = Bool(true)
+	}
 
 	traceparent, tracestate := getTraceContext(ctx)
 	req.Traceparent = traceparent
@@ -841,7 +843,9 @@ func (c *Client) ResumeSessionWithOptions(ctx context.Context, sessionID string,
 	req.InfiniteSessions = config.InfiniteSessions
 	req.GitHubToken = config.GitHubToken
 	req.RemoteSession = config.RemoteSession
-	req.RequestPermission = Bool(true)
+	if config.OnPermissionRequest != nil {
+		req.RequestPermission = Bool(true)
+	}
 
 	if len(config.Commands) > 0 {
 		cmds := make([]wireCommand, 0, len(config.Commands))

nodejs/src/client.ts

@@ -863,7 +863,7 @@ export class CopilotClient {
                 provider: config.provider,
                 enableSessionTelemetry: config.enableSessionTelemetry,
                 modelCapabilities: config.modelCapabilities,
-                requestPermission: true,
+                requestPermission: !!config.onPermissionRequest,
                 requestUserInput: !!config.onUserInputRequest,
                 requestElicitation: !!config.onElicitationRequest,
                 requestExitPlanMode: !!config.onExitPlanModeRequest,

python/copilot/client.py

@@ -1509,8 +1509,8 @@ async def create_session(
         if excluded_tools is not None:
             payload["excludedTools"] = excluded_tools
 
-        # Always enable permission request callback
-        payload["requestPermission"] = True
+        # Enable permission request callback if handler provided
+        payload["requestPermission"] = bool(on_permission_request)
 
         # Enable user input request callback if handler provided
         if on_user_input_request:
@@ -1904,8 +1904,8 @@ async def resume_session(
             else True
         )
 
-        # Always enable permission request callback
-        payload["requestPermission"] = True
+        # Enable permission request callback if handler provided
+        payload["requestPermission"] = bool(on_permission_request)
 
         if on_user_input_request:
             payload["requestUserInput"] = True