Skip to content

Commit ecdc5ec

Browse files
github-actions[bot]stephentoubCopilot
authored
Update @github/copilot to 1.0.39 (#1167)
* Update @github/copilot to 1.0.39 - Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code * Fix flaky multi-client reject permission test Mirror the synchronization pattern from the 'approve' sibling: capture a PermissionCompletedEvent task on session2 before subscribing and sending, then await it before asserting that client2 observed PermissionRequestedEvent. Without this wait, client2's event subscription could be asserted before the event had propagated, causing intermittent failures (observed on macOS CI). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 02ff69b commit ecdc5ec

10 files changed

Lines changed: 128 additions & 59 deletions

File tree

dotnet/src/Generated/SessionEvents.cs

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dotnet/test/MultiClientTests.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,9 @@ public async Task One_Client_Rejects_Permission_And_Both_See_The_Result()
220220
var client1Events = new ConcurrentBag<SessionEvent>();
221221
var client2Events = new ConcurrentBag<SessionEvent>();
222222

223+
// Wait for PermissionCompletedEvent on client2 which may arrive slightly after session1 goes idle
224+
var client2PermissionCompleted = TestHelper.GetNextEventOfTypeAsync<PermissionCompletedEvent>(session2);
225+
223226
using var sub1 = session1.On(evt => client1Events.Add(evt));
224227
using var sub2 = session2.On(evt => client2Events.Add(evt));
225228

@@ -235,6 +238,8 @@ await session1.SendAndWaitAsync(new MessageOptions
235238
var content = await File.ReadAllTextAsync(Path.Combine(Ctx.WorkDir, "protected.txt"));
236239
Assert.Equal("protected content", content);
237240

241+
await client2PermissionCompleted;
242+
238243
Assert.Contains(client1Events, e => e is PermissionRequestedEvent);
239244
Assert.Contains(client2Events, e => e is PermissionRequestedEvent);
240245

go/generated_session_events.go

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/package-lock.json

Lines changed: 28 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"author": "GitHub",
5757
"license": "MIT",
5858
"dependencies": {
59-
"@github/copilot": "^1.0.39-0",
59+
"@github/copilot": "^1.0.39",
6060
"vscode-jsonrpc": "^8.2.1",
6161
"zod": "^4.3.6"
6262
},

nodejs/samples/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nodejs/src/generated/session-events.ts

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/copilot/generated/session_events.py

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)