Commit f1038d7
Hide CLI console window on Windows across all SDKs (#329)
* Initial plan
* Add hide_cli_window option to suppress console window on Windows
Co-authored-by: patniko <26906478+patniko@users.noreply.github.com>
* Address code review feedback: use conditional kwargs and idiomatic assertions
Co-authored-by: patniko <26906478+patniko@users.noreply.github.com>
* Make hiding CLI window default behavior across all SDKs
- Python: Always hide window on Windows (removed hide_cli_window option)
- Node.js: Add windowsHide: true to spawn options
- Go: Add SysProcAttr with HideWindow on Windows via platform-specific files
- .NET: Already had CreateNoWindow = true
This ensures consistent behavior across all SDKs where the CLI subprocess
console window is hidden on Windows to avoid distracting users in GUI apps.
Co-authored-by: SteveSandersonMS <1101362+SteveSandersonMS@users.noreply.github.com>
* Fix Go build
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: patniko <26906478+patniko@users.noreply.github.com>
Co-authored-by: SteveSandersonMS <1101362+SteveSandersonMS@users.noreply.github.com>
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>1 parent 273c425 commit f1038d7
File tree
5 files changed
+37
-0
lines changed- go
- nodejs/src
- python/copilot
5 files changed
+37
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1056 | 1056 | | |
1057 | 1057 | | |
1058 | 1058 | | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
1059 | 1062 | | |
1060 | 1063 | | |
1061 | 1064 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1053 | 1053 | | |
1054 | 1054 | | |
1055 | 1055 | | |
| 1056 | + | |
1056 | 1057 | | |
1057 | 1058 | | |
1058 | 1059 | | |
1059 | 1060 | | |
1060 | 1061 | | |
1061 | 1062 | | |
| 1063 | + | |
1062 | 1064 | | |
1063 | 1065 | | |
1064 | 1066 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1167 | 1167 | | |
1168 | 1168 | | |
1169 | 1169 | | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
1170 | 1173 | | |
1171 | 1174 | | |
1172 | 1175 | | |
| |||
1179 | 1182 | | |
1180 | 1183 | | |
1181 | 1184 | | |
| 1185 | + | |
1182 | 1186 | | |
1183 | 1187 | | |
1184 | 1188 | | |
| |||
1190 | 1194 | | |
1191 | 1195 | | |
1192 | 1196 | | |
| 1197 | + | |
1193 | 1198 | | |
1194 | 1199 | | |
1195 | 1200 | | |
| |||
0 commit comments