Commit f6a669d
Drop redundant RuntimeConnection + COPILOT_CLI_PATH from scenarios
Most scenarios explicitly set up a stdio connection from COPILOT_CLI_PATH:
- .NET: Connection = RuntimeConnection.ForStdio(path: Environment.GetEnvironmentVariable("COPILOT_CLI_PATH"))
- TS: connection: RuntimeConnection.forStdio({ path: process.env.COPILOT_CLI_PATH })
This is redundant boilerplate:
- The default `RuntimeConnection` is already stdio across every SDK.
- When no `path` is given, the SDKs already fall back to the
`COPILOT_CLI_PATH` env var (and then the bundled binary), so the
explicit pass-through adds nothing.
- No real consumer of the SDK would write this — the docs reasonably
expect `new CopilotClient()` (or the language-equivalent) to Just Work.
Drop the connection setup entirely in every scenario *except* those whose
whole purpose is to demonstrate transport / bundling configuration:
- `transport/stdio` — explicit stdio path is the point.
- `transport/tcp` / `transport/reconnect` — TCP transport is the point.
- `bundling/*` — bundled-binary lookup is the point.
Also clean up the resulting cruft:
- Empty `new CopilotClientOptions {}` / `new CopilotClient({})` literals
collapsed to parameter-less constructors.
- Unused `RuntimeConnection` imports stripped from TS scenarios.
- Go scenarios that previously passed `&copilot.ClientOptions{}` now
pass `nil` (idiomatic when no fields are set).
- The `cliPath` local var in `tools/custom-agents` (.NET) deleted.
Rust scenarios keep `ClientOptions::default()` because the API requires
the argument — that's idiomatic Rust, not redundant boilerplate.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 2a77f12 commit f6a669d
80 files changed
Lines changed: 192 additions & 262 deletions
File tree
- test/scenarios
- auth
- byok-anthropic
- csharp
- go
- typescript/src
- byok-azure
- csharp
- go
- typescript/src
- byok-ollama
- csharp
- go
- typescript/src
- byok-openai
- csharp
- go
- typescript/src
- gh-app
- csharp
- typescript/src
- bundling
- app-backend-to-server/typescript/src
- fully-bundled
- go
- typescript/src
- callbacks
- hooks
- csharp
- go
- typescript/src
- permissions
- csharp
- go
- typescript/src
- user-input
- csharp
- go
- typescript/src
- modes
- default
- csharp
- go
- typescript/src
- minimal
- csharp
- go
- typescript/src
- prompts
- attachments
- csharp
- go
- typescript/src
- reasoning-effort
- csharp
- go
- typescript/src
- system-message
- csharp
- go
- typescript/src
- sessions
- concurrent-sessions
- csharp
- go
- typescript/src
- infinite-sessions
- csharp
- go
- typescript/src
- multi-user-long-lived/typescript/src
- multi-user-short-lived/typescript/src
- session-resume
- csharp
- go
- typescript/src
- streaming
- csharp
- go
- typescript/src
- tools
- custom-agents
- csharp
- go
- typescript/src
- mcp-servers
- csharp
- go
- typescript/src
- no-tools
- csharp
- go
- typescript/src
- skills
- csharp
- go
- typescript/src
- tool-filtering
- csharp
- go
- typescript/src
- tool-overrides
- csharp
- go
- typescript/src
- virtual-filesystem
- csharp
- go
- typescript/src
- transport
- reconnect/typescript/src
- stdio
- go
- typescript/src
- tcp/typescript/src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 13 | + | |
17 | 14 | | |
18 | 15 | | |
19 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
| 12 | + | |
15 | 13 | | |
16 | 14 | | |
17 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 14 | + | |
18 | 15 | | |
19 | 16 | | |
20 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 13 | + | |
16 | 14 | | |
17 | 15 | | |
18 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
| 9 | + | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | | - | |
11 | | - | |
12 | | - | |
| 11 | + | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 13 | + | |
17 | 14 | | |
18 | 15 | | |
19 | 16 | | |
| |||
0 commit comments