Skip to content

Commit fbd56e3

Browse files
authored
Java: make it so deps are correctly updated at release (#1560)
1 parent f3b95bb commit fbd56e3

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/java-publish-maven.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,13 +172,16 @@ jobs:
172172
run: |
173173
VERSION="${{ steps.versions.outputs.release_version }}"
174174
175-
# Update version in README.md (supports any version qualifier like -java.N, -java-preview.N, -beta-java.N)
175+
# Update release version in README.md (supports any version qualifier like -java.N, -java-preview.N, -beta-java.N)
176176
sed -i "s|<version>[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(-[a-z][a-z0-9-]*\.[0-9][0-9]*\)*</version>|<version>${VERSION}</version>|g" README.md
177177
sed -i "s|copilot-sdk-java:[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(-[a-z][a-z0-9-]*\.[0-9][0-9]*\)*|copilot-sdk-java:${VERSION}|g" README.md
178178
179-
# Update snapshot version in README.md
179+
# Update snapshot versions in README.md (must run AFTER release version seds
180+
# because the release copilot-sdk-java: pattern partially matches inside snapshot
181+
# strings — the snapshot-specific seds override with the correct DEV_VERSION)
180182
DEV_VERSION="${{ steps.versions.outputs.dev_version }}"
181183
sed -i "s|<version>[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(-[a-z][a-z0-9-]*\.[0-9][0-9]*\)*-SNAPSHOT</version>|<version>${DEV_VERSION}</version>|g" README.md
184+
sed -i "s|copilot-sdk-java:[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(-[a-z][a-z0-9-]*\.[0-9][0-9]*\)*-SNAPSHOT|copilot-sdk-java:${DEV_VERSION}|g" README.md
182185
183186
# Update version in jbang-example.java
184187
sed -i "s|copilot-sdk-java:[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(-[a-z][a-z0-9-]*\.[0-9][0-9]*\)*|copilot-sdk-java:${VERSION}|g" jbang-example.java
@@ -312,4 +315,3 @@ jobs:
312315
echo "Triggered deploy-site.yml on github/copilot-sdk-java for version ${VERSION}" >> $GITHUB_STEP_SUMMARY
313316
env:
314317
GITHUB_TOKEN: ${{ secrets.JAVA_RELEASE_GITHUB_TOKEN }}
315-

0 commit comments

Comments
 (0)