Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Generated by SDK Consistency Review Agent for issue #1022
Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerated RPC types and added modelCapabilities support to Python, Go, and C# SDKs to match the Node.js implementation. All languages now support: - modelCapabilities on createSession/create_session/CreateSession - modelCapabilities on setModel/set_model/SetModel/SetModelAsync - E2E tests verifying vision toggle via setModel changes image processing Also includes: - Regenerated codegen output with proper type names (no Purple/Fluffy) - C# codegen fix to respect JSON Schema 'title' for class naming - Fix Go E2E tests for DataContent type change in session events - Fix Python generated Union import in session events Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b14e5b6 to
cf12a7f
Compare
Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>
cf12a7f to
2e943bf
Compare
- Replace foreach loops with LINQ .Where/.Any in HasImageUrlContent - Fix Python import ordering (ruff) - Apply formatter output across Node/Python Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Addresses Cross-SDK Consistency Review: - Add modelCapabilities to ResumeSessionConfig Pick list - Forward modelCapabilities in session.resume RPC call Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Cross-SDK Consistency Review ✅This PR adds Python already implements this feature — All four SDKs are consistent:
No cross-SDK consistency issues found.
|
Contributor
Author
|
This PR was merged prematurely in error by the branch's upstream tracking branch being wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
modelCapabilitiesparameter to the Node SDK'screateSessionandsetModelAPIs, allowing SDK consumers to override individual model capabilities (e.g., vision support) without specifying the full capabilities object.Closes #994
Changes
modelCapabilitiestomodel.switchTo)ModelCapabilitiesOverridetype, exported from indexcreateSessionandsetModelaccept optionalmodelCapabilitiessetModelchanges image processing behaviorUsage
Testing
E2E tests run against a local runtime build and verify that:
setModelcausesimage_urlcontent to appearsetModelcausesimage_urlcontent to stop appearing