C# API review fixes#1343

Open

SteveSandersonMS wants to merge 34 commits into

mainfrom

stevesandersonms/stevesa-api-review-fixes

Commits on May 20, 2026

Phase 1: codegen falls back to JsonElement instead of object

SteveSandersonMS
and
Copilot
committed
Phase 3: seal hand-written public types

SteveSandersonMS
and
Copilot
committed
Phase 4a: simple property/method renames

SteveSandersonMS
and
Copilot
committed
Phase 4b: expand SessionFsProvider abbreviations

SteveSandersonMS
and
Copilot
committed
Phase 4c: shape changes (Streaming, Tools, ToolBinaryResultType, cleanups)

SteveSandersonMS
and
Copilot
committed
Phase 4d/4e: remove CopilotClient.State, retype LogLevel

SteveSandersonMS
and
Copilot
committed
Fix mojibake from cp1252/UTF-8 round-trip in earlier phase commits

SteveSandersonMS
and
Copilot
committed
Phase 4f: generic OnLifecycle<T> + On<T>, polymorphic lifecycle events

SteveSandersonMS
and
Copilot
committed
Phase 4g: DateTimeOffset timestamps + PermissionRequestResult.Feedback

SteveSandersonMS
and
Copilot
committed
Phase 7: SendAsync(string) / SendAndWaitAsync(string) convenience overloads

SteveSandersonMS
and
Copilot
committed
Phase 9 (partial): rename Cwd/Remote properties on hand-written types

SteveSandersonMS
and
Copilot
committed
Phase 8: README updates for OnLifecycle<T> and lifecycle event types

SteveSandersonMS
and
Copilot
committed
Phase 5: extract SessionConfigBase; seal config classes

SteveSandersonMS
and
Copilot
committed
Phase 6: remove named delegate types, use Func<...>

SteveSandersonMS
and
Copilot
committed
Phase 9: introduce RuntimeConnection discriminated config

SteveSandersonMS
and
Copilot
committed
README: update Custom Permission Handler section for Phase 6 delegate removal

SteveSandersonMS
and
Copilot
committed
Re-run C# codegen to pick up Phase 1 JsonElement fallback consistently

SteveSandersonMS
and
Copilot
committed
Fix snapshot capture locally
SteveSandersonMS
committed
Fix MCP config serialization
SteveSandersonMS
committed
Revert "Phase 1: codegen falls back to JsonElement instead of object"
SteveSandersonMS
committed
Post-revert cleanup for Phase 1 revert

SteveSandersonMS
and
Copilot
committed
Revert "Fix MCP config serialization"
SteveSandersonMS
committed
Fixes to E2E tests to restore main behavior
SteveSandersonMS
committed
Restore TCP transport for two ClientOptions tests

SteveSandersonMS
and
Copilot
committed
Test harness: throw if both useStdio and Connection are supplied

SteveSandersonMS
and
Copilot
committed
Revert accidental CapiProxy.cs change

SteveSandersonMS
and
Copilot
committed
Test fix
SteveSandersonMS
committed
Update C# doc snippets for renamed APIs

SteveSandersonMS
and
Copilot
committed
Update C# test scenarios for renamed APIs

SteveSandersonMS
and
Copilot
committed
Drop .SDK from C# namespaces

SteveSandersonMS
and
Copilot
committed
Fix local test runs
SteveSandersonMS
committed
Drop unused uriConn binding in Client.cs is-check

SteveSandersonMS
and
Copilot
committed
Address Copilot review feedback

SteveSandersonMS
and
Copilot
committed
Docs validation: prepend 'using GitHub.Copilot;' after namespace rename

SteveSandersonMS
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C# API review fixes#1343

C# API review fixes#1343
SteveSandersonMS wants to merge 34 commits into
mainfrom
stevesandersonms/stevesa-api-review-fixes

Commits on May 20, 2026

Phase 1: codegen falls back to JsonElement instead of object

Phase 3: seal hand-written public types

Phase 4a: simple property/method renames

Phase 4b: expand SessionFsProvider abbreviations

Phase 4c: shape changes (Streaming, Tools, ToolBinaryResultType, cleanups)

Phase 4d/4e: remove CopilotClient.State, retype LogLevel

Fix mojibake from cp1252/UTF-8 round-trip in earlier phase commits

Phase 4f: generic OnLifecycle<T> + On<T>, polymorphic lifecycle events

Phase 4g: DateTimeOffset timestamps + PermissionRequestResult.Feedback

Phase 7: SendAsync(string) / SendAndWaitAsync(string) convenience overloads

Phase 9 (partial): rename Cwd/Remote properties on hand-written types

Phase 8: README updates for OnLifecycle<T> and lifecycle event types

Phase 5: extract SessionConfigBase; seal config classes

Phase 6: remove named delegate types, use Func<...>

Phase 9: introduce RuntimeConnection discriminated config

README: update Custom Permission Handler section for Phase 6 delegate removal

Re-run C# codegen to pick up Phase 1 JsonElement fallback consistently

Fix snapshot capture locally

Fix MCP config serialization

Revert "Phase 1: codegen falls back to JsonElement instead of object"

Post-revert cleanup for Phase 1 revert

Revert "Fix MCP config serialization"

Fixes to E2E tests to restore main behavior

Restore TCP transport for two ClientOptions tests

Test harness: throw if both useStdio and Connection are supplied

Revert accidental CapiProxy.cs change

Test fix

Update C# doc snippets for renamed APIs

Update C# test scenarios for renamed APIs

Drop .SDK from C# namespaces

Fix local test runs

Drop unused uriConn binding in Client.cs is-check

Address Copilot review feedback

Docs validation: prepend 'using GitHub.Copilot;' after namespace rename