address comments

Author: piceri

pkg/deploymentrecord/client.go

@@ -267,7 +267,7 @@ func (c *Client) PostOne(ctx context.Context, record *DeploymentRecord) error {
 		_ = resp.Body.Close()
 
 		switch {
-		case resp.StatusCode == 404 && bytes.Contains(respBody, []byte("no artifacts found")):
+		case resp.StatusCode == 404:
 			// No artifact found
 			dtmetrics.PostDeploymentRecordNoAttestation.Inc()
 			slog.Debug("no artifact attestation found, no record created",
@@ -279,7 +279,7 @@ func (c *Client) PostOne(ctx context.Context, record *DeploymentRecord) error {
 			return &NoArtifactError{err: fmt.Errorf("no attestation found for %s", record.Digest)}
 		case resp.StatusCode >= 400 && resp.StatusCode < 500:
 			if resp.Header.Get("retry-after") != "" || resp.Header.Get("x-ratelimit-remaining") == "0" {
-				// rate limited — retry with backoff
+				// Rate limited — retry with backoff
 				// Could be 403 or 429
 				dtmetrics.PostDeploymentRecordRateLimited.Inc()
 				slog.Warn("rate limited, retrying",

pkg/deploymentrecord/client_test.go

@@ -356,33 +356,33 @@ func TestPostOne(t *testing.T) {
 			wantNoAttestation: 1,
 		},
 		{
-			name:   "404 without no artifacts found returns ClientError",
+			name:   "400 returns ClientError",
 			record: testRecord(),
 			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.WriteHeader(http.StatusNotFound)
-				_, _ = w.Write([]byte(`{"message":"not found"}`))
+				w.WriteHeader(http.StatusBadRequest)
+				_, _ = w.Write([]byte("bad request"))
 			},
 			wantErr:         true,
 			errType:         &ClientError{},
 			wantClientError: 1,
 		},
 		{
-			name:   "400 returns ClientError",
+			name:   "403 forbidden returns ClientError",
 			record: testRecord(),
 			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.WriteHeader(http.StatusBadRequest)
-				_, _ = w.Write([]byte("bad request"))
+				w.WriteHeader(http.StatusForbidden)
+				_, _ = w.Write([]byte(`{"message":"forbidden"}`))
 			},
 			wantErr:         true,
 			errType:         &ClientError{},
 			wantClientError: 1,
 		},
 		{
-			name:   "403 forbidden returns ClientError",
+			name:   "422 invalid body returns ClientError",
 			record: testRecord(),
 			handler: func(w http.ResponseWriter, _ *http.Request) {
-				w.WriteHeader(http.StatusForbidden)
-				_, _ = w.Write([]byte(`{"message":"forbidden"}`))
+				w.WriteHeader(http.StatusUnprocessableEntity)
+				_, _ = w.Write([]byte("invalid body"))
 			},
 			wantErr:         true,
 			errType:         &ClientError{},