rename deptracker_post_record_no_attestation to deptracker_post_record_unknown_artifact

Signed-off-by: Eric Pickard <piceri@github.com>

Author: piceri

README.md

@@ -193,7 +193,7 @@ The metrics exposed beyond the default Prometheus metrics are:
   record uploads.
 * `deptracker_post_record_rate_limited`: the number of post attempts
   that were rate limited.
-* `deptracker_post_record_no_attestation`: the number of attempts
+* `deptracker_post_record_unknown_artifact`: the number of attempts
   that resulted in no matching attestation for the container digest
   (404 "no artifacts found" responses).
 * `deptracker_post_record_soft_fail`: the number of recoverable failed

pkg/deploymentrecord/client.go

@@ -265,7 +265,7 @@ func (c *Client) PostOne(ctx context.Context, record *DeploymentRecord) error {
 		switch {
 		case resp.StatusCode == 404:
 			// No artifact found - do not retry
-			dtmetrics.PostDeploymentRecordNoAttestation.Inc()
+			dtmetrics.PostDeploymentRecordUnknownArtifact.Inc()
 			slog.Debug("no artifact attestation found, no record created",
 				"attempt", attempt,
 				"status_code", resp.StatusCode,

pkg/deploymentrecord/client_test.go

@@ -298,7 +298,7 @@ func testRecord() *DeploymentRecord {
 func allCounters() []prometheus.Counter {
 	return []prometheus.Counter{
 		dtmetrics.PostDeploymentRecordOk,
-		dtmetrics.PostDeploymentRecordNoAttestation,
+		dtmetrics.PostDeploymentRecordUnknownArtifact,
 		dtmetrics.PostDeploymentRecordRateLimited,
 		dtmetrics.PostDeploymentRecordSoftFail,
 		dtmetrics.PostDeploymentRecordHardFail,
@@ -308,19 +308,19 @@ func allCounters() []prometheus.Counter {
 
 func TestPostOne(t *testing.T) {
 	tests := []struct {
-		name              string
-		record            *DeploymentRecord
-		retries           int
-		handler           http.HandlerFunc
-		wantErr           bool
-		errType           any // expected error type for errors.As
-		errContain        string
-		wantOk            float64
-		wantNoAttestation float64
-		wantRateLimited   float64
-		wantSoftFail      float64
-		wantHardFail      float64
-		wantClientError   float64
+		name                string
+		record              *DeploymentRecord
+		retries             int
+		handler             http.HandlerFunc
+		wantErr             bool
+		errType             any // expected error type for errors.As
+		errContain          string
+		wantOk              float64
+		wantUnknownArtifact float64
+		wantRateLimited     float64
+		wantSoftFail        float64
+		wantHardFail        float64
+		wantClientError     float64
 	}{
 		{
 			name:   "success on 200",
@@ -354,10 +354,10 @@ func TestPostOne(t *testing.T) {
 				w.WriteHeader(http.StatusNotFound)
 				_, _ = w.Write([]byte(`{"message":"no artifacts found"}`))
 			},
-			wantErr:           true,
-			errType:           &NoArtifactError{},
-			errContain:        "sha256:abc123",
-			wantNoAttestation: 1,
+			wantErr:             true,
+			errType:             &NoArtifactError{},
+			errContain:          "sha256:abc123",
+			wantUnknownArtifact: 1,
 		},
 		{
 			name:   "400 returns ClientError",
@@ -555,15 +555,15 @@ func TestPostOne(t *testing.T) {
 			// Assert all metric deltas
 			wantDeltas := []float64{
 				tt.wantOk,
-				tt.wantNoAttestation,
+				tt.wantUnknownArtifact,
 				tt.wantRateLimited,
 				tt.wantSoftFail,
 				tt.wantHardFail,
 				tt.wantClientError,
 			}
 			names := []string{
 				"PostDeploymentRecordOk",
-				"PostDeploymentRecordNoAttestation",
+				"PostDeploymentRecordUnknownArtifact",
 				"PostDeploymentRecordRateLimited",
 				"PostDeploymentRecordSoftFail",
 				"PostDeploymentRecordHardFail",

pkg/dtmetrics/prom.go

@@ -50,9 +50,9 @@ var (
 	)
 
 	//nolint: revive
-	PostDeploymentRecordNoAttestation = promauto.NewCounter(
+	PostDeploymentRecordUnknownArtifact = promauto.NewCounter(
 		prometheus.CounterOpts{
-			Name: "deptracker_post_record_no_attestation",
+			Name: "deptracker_post_record_unknown_artifact",
 			Help: "The total number of post attempts that resulted in no matching attestation for the container digest (404 'no artifacts found' responses)",
 		},
 	)