Skip to content

Commit 274e668

Browse files
authored
Merge pull request #13792 from github/repo-sync
repo sync
2 parents c7b0e8c + 3f60a0f commit 274e668

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

components/page-header/Header.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,16 @@ export const Header = () => {
3333
}
3434
}, [])
3535

36+
useEffect(() => {
37+
const close = (e: { key: string }) => {
38+
if (e.key === 'Escape') {
39+
setIsMenuOpen(false)
40+
}
41+
}
42+
window.addEventListener('keydown', close)
43+
return () => window.removeEventListener('keydown', close)
44+
}, [])
45+
3646
return (
3747
<div
3848
className={cx(
@@ -89,7 +99,7 @@ export const Header = () => {
8999
</Link>
90100
</div>
91101

92-
<div>
102+
<nav>
93103
<button
94104
className="btn"
95105
data-testid="mobile-menu-button"
@@ -99,7 +109,7 @@ export const Header = () => {
99109
>
100110
{isMenuOpen ? <XIcon size="small" /> : <ThreeBarsIcon size="small" />}
101111
</button>
102-
</div>
112+
</nav>
103113
</div>
104114

105115
{/* mobile menu contents */}

components/ui/Picker/Picker.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function PickerSummaryWrapper({ variant, children }: PickerWrapperPropsT) {
3434
return (
3535
<>
3636
{children}
37-
<Dropdown.Caret />
37+
<ChevronDownIcon size={16} className="arrow ml-md-1" />
3838
</>
3939
)
4040
}

0 commit comments

Comments
 (0)