Merge branch 'main' into patch-1

Author: thesomewhatyou

.devcontainer/Dockerfile

@@ -1,5 +1,3 @@
 # To find available Node images, see https://mcr.microsoft.com/en-us/product/devcontainers/javascript-node/tags
-
-# [Choice] Node.js version
-ARG VARIANT="dev-24-bullseye"
-FROM mcr.microsoft.com/devcontainers/javascript-node:${VARIANT}
+ARG VARIANT=dev-24-bullseye
+FROM mcr.microsoft.com/devcontainers/javascript-node:dev-24-bullseye@sha256:3502f1f21b1989500e8c72ada7d6e496dc4540b0707d4ea4ff743077f88a6c2d

.devcontainer/devcontainer.json

@@ -63,7 +63,7 @@
 
   // Lifecycle commands
   // Start a web server and keep it running
-  "postStartCommand": "nohup bash -c 'npm start &'",
+  "postStartCommand": "nohup bash -c 'npm ci && npm start &'",
   // Set port 4000 to be public
   "postAttachCommand": "gh cs ports visibility 4000:public -c \"$CODESPACE_NAME\"",
 

.github/workflows/index-general-search.yml

@@ -26,9 +26,11 @@ on:
 permissions:
   contents: read
 
-# This allows a subsequently queued workflow run to cancel previous runs
+# This allows a subsequently queued workflow run to cancel previous runs.
+# Include the triggering workflow's conclusion in the group so that runs triggered
+# by skipped Purge Fastly workflows don't cancel runs triggered by successful ones.
 concurrency:
-  group: '${{ github.workflow }} @ ${{ github.head_ref }} ${{ github.event_name }}'
+  group: '${{ github.workflow }} @ ${{ github.head_ref }} ${{ github.event_name }} ${{ github.event.workflow_run.conclusion }}'
   cancel-in-progress: true
 
 env:
@@ -40,7 +42,9 @@ env:
 
 jobs:
   figureOutMatrix:
-    if: ${{ github.repository == 'github/docs-internal' }}
+    # Skip immediately if triggered by a non-successful Purge Fastly run.
+    # This prevents skipped runs from canceling valid indexing runs via concurrency.
+    if: ${{ github.repository == 'github/docs-internal' && (github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success') }}
     runs-on: ubuntu-latest
     outputs:
       matrix: ${{ steps.set-matrix.outputs.result }}
@@ -55,11 +59,13 @@ jobs:
             const allPossible = ["en", ...allNonEnglish]
 
             if (context.eventName === "workflow_run") {
+              // Job-level `if` already ensures we only get here for successful runs,
+              // but keep this as a safety check.
               if (context.payload.workflow_run.conclusion === "success") {
                 return ["en"]
               }
-              console.warn(`NOTE! It was a workflow_run but not success ('${context.payload.workflow_run.conclusion}')`)
-              console.warn("This means we're not going to index anything in the next dependent step.")
+              // This shouldn't happen due to job-level filter, but handle gracefully.
+              console.warn(`Unexpected: workflow_run with conclusion '${context.payload.workflow_run.conclusion}'`)
               return []
             }
 

.github/workflows/link-check-daily.yml

@@ -0,0 +1,78 @@
+name: Check External Links
+
+# Runs weekly (Wednesday) at 16:20 UTC
+# Validates external URLs in content files
+
+on:
+  schedule:
+    - cron: '20 16 * * 3' # Wednesday at 16:20 UTC
+  workflow_dispatch:
+    inputs:
+      max_urls:
+        description: 'Maximum number of URLs to check (leave blank for all)'
+        type: number
+
+permissions:
+  contents: read
+  issues: write
+
+jobs:
+  check-external-links:
+    if: github.repository == 'github/docs-internal'
+    runs-on: ubuntu-latest
+    timeout-minutes: 180 # 3 hours for external checks
+    steps:
+      - name: Checkout
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+
+      - uses: ./.github/actions/node-npm-setup
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Check external links
+        env:
+          ACTION_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+          CACHE_MAX_AGE_DAYS: '7'
+        run: |
+          if [[ -n "${{ inputs.max_urls }}" ]]; then
+            npm run check-links-external -- --max ${{ inputs.max_urls }}
+          else
+            npm run check-links-external
+          fi
+
+      - name: Upload report artifact
+        if: always()
+        uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
+        with:
+          name: external-link-report
+          path: artifacts/external-link-report.*
+          retention-days: 14
+          if-no-files-found: ignore
+
+      - name: Check if report exists
+        if: always()
+        id: check_report
+        run: |
+          if [ -f "artifacts/external-link-report.md" ]; then
+            echo "has_report=true" >> $GITHUB_OUTPUT
+          else
+            echo "has_report=false" >> $GITHUB_OUTPUT
+            echo "No broken link report generated - all links valid!"
+          fi
+
+      - name: Create issue if broken links found
+        if: always() && steps.check_report.outputs.has_report == 'true'
+        uses: peter-evans/create-issue-from-file@fca9117c27cdc29c6c4db3b86c48e4115a786710 # v5
+        with:
+          token: ${{ secrets.DOCS_BOT_PAT_BASE }}
+          repository: github/docs-content
+          title: '🌐 Broken External Links Report'
+          content-filepath: artifacts/external-link-report.md
+          labels: broken link report
+
+      - uses: ./.github/actions/slack-alert
+        if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
+        with:
+          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
+          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}