Fix Slack alert logic (#45044)

Author: Peter Bengtsson

.github/actions/slack-alert/action.yml

@@ -14,13 +14,6 @@ runs:
   steps:
     - name: Send Slack notification if workflow fails
       uses: someimportantcompany/github-actions-slack-message@1d367080235edfa53df415bd8e0bbab480f29bad
-      if: >-
-        ${{
-          failure() &&
-          github.repository == 'github/docs-internal' &&
-          github.event_name != 'pull_request' &&
-          github.event_name != 'pull_request_target'
-        }}
       with:
         channel: ${{ inputs.slack_channel_id }}
         bot-token: ${{ inputs.slack_token }}

.github/workflows/add-review-template.yml

@@ -37,8 +37,3 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.DOCS_BOT_PAT_WORKFLOW_READORG }}
           PR: ${{ github.event.pull_request.html_url }}
           TEMPLATE: ${{ env.TEMPLATE }}
-
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/auto-close-dependencies.yml

@@ -66,9 +66,3 @@ jobs:
               console.error(`Failed to lock the pull request. Error: ${error}`)
               throw error
             }
-      - name: Check out repo
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/azure-preview-env-deploy.yml

@@ -254,8 +254,3 @@ jobs:
         # The `--fail --retry N` combination means that a 4xx response
         # code will exit immediately but a 5xx will exhaust the retries.
         run: curl --fail --retry-connrefused --retry 5 -I ${{ env.APP_URL }}
-
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/azure-preview-env-destroy.yml

@@ -70,8 +70,3 @@ jobs:
           # The token provided by the workflow does not have the permissions to delete created environments
           token: ${{ secrets.DOCS_BOT_PAT_READPUBLICKEY }}
           environment: preview-env-${{ env.PR_NUMBER }}
-
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/azure-prod-build-deploy.yml

@@ -147,6 +147,7 @@ jobs:
           az webapp deployment slot swap --slot canary --target-slot production -n ghdocs-prod -g docs-prod
 
       - uses: ./.github/actions/slack-alert
+        if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
         with:
           slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/azure-staging-build-deploy.yml

@@ -157,8 +157,3 @@ jobs:
       - name: 'Swap deployment slot to production'
         run: |
           az webapp deployment slot swap --slot ${{ env.SLOT_NAME }} --target-slot production -n ${{ env.APP_SERVICE_NAME }} -g ${{ env.RESOURCE_GROUP_NAME }}
-
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/check-broken-links-github-github.yml

@@ -88,6 +88,7 @@ jobs:
           labels: ${{ env.REPORT_LABEL }}
 
       - uses: ./.github/actions/slack-alert
+        if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
         with:
           slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/check-for-spammy-issues.yml

@@ -80,10 +80,3 @@ jobs:
             } catch (error) {
               console.log(error);
             }
-
-      - name: Check out repo
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

.github/workflows/close-bad-repo-sync-prs.yml

@@ -60,10 +60,3 @@ jobs:
               issue_number: prNumber,
               body: "Please leave this `repo-sync` branch to the robots!\n\nI'm going to close this pull request now, but feel free to open a new issue or ask any questions in [discussions](https://github.com/github/docs/discussions)!"
             })
-
-      - name: Check out repo
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
-      - uses: ./.github/actions/slack-alert
-        with:
-          slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
-          slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}