Fix link checker: validate assets on disk, compact redirects, no alerts (#59358)

Author: heiskr

.github/workflows/link-check-internal.yml

@@ -89,12 +89,13 @@ jobs:
         run: npm run check-links-internal
 
       - name: Upload report artifact
-        if: failure()
+        if: always()
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
           name: link-report-${{ matrix.version }}-${{ matrix.language }}
           path: artifacts/link-report-*.md
           retention-days: 5
+          if-no-files-found: ignore
 
       - uses: ./.github/actions/slack-alert
         if: ${{ failure() && github.event_name != 'workflow_dispatch' }}

src/links/lib/extract-links.ts

@@ -337,3 +337,21 @@ export function checkInternalLink(
 
   return { exists: false, isRedirect: false }
 }
+
+/**
+ * Check if an asset link points to an existing file on disk
+ */
+export function checkAssetLink(href: string): boolean {
+  if (!href.startsWith('/assets/')) {
+    return false // Not an asset link
+  }
+  const assetPath = path.resolve(href.slice(1)) // Remove leading /
+  return fs.existsSync(assetPath)
+}
+
+/**
+ * Check if a link is an asset link (starts with /assets/)
+ */
+export function isAssetLink(href: string): boolean {
+  return href.startsWith('/assets/')
+}

src/links/lib/link-report.ts

@@ -122,9 +122,7 @@ ${errors
 
     const warningSection =
       warnings.length > 0
-        ? `### ⚠️ ${warnings.length} Redirect${warnings.length === 1 ? '' : 's'} to Update
-
-${warnings.map((group) => `- \`${group.target}\` → \`${group.occurrences[0]?.redirectTarget || '?'}\``).join('\n')}
+        ? `### ℹ️ ${warnings.length} redirect${warnings.length === 1 ? '' : 's'} to update
 
 `
         : ''

src/links/scripts/check-links-internal.ts

@@ -26,7 +26,12 @@ import warmServer from '@/frame/lib/warm-server'
 import { renderContent } from '@/content-render/index'
 import { allVersions, allVersionKeys } from '@/versions/lib/all-versions'
 import languages from '@/languages/lib/languages-server'
-import { normalizeLinkPath, checkInternalLink } from '@/links/lib/extract-links'
+import {
+  normalizeLinkPath,
+  checkInternalLink,
+  checkAssetLink,
+  isAssetLink,
+} from '@/links/lib/extract-links'
 import {
   type BrokenLink,
   generateInternalLinkReport,
@@ -183,6 +188,19 @@ async function checkVersion(
     for (const link of links) {
       if (isExcludedLink(link.href)) continue
 
+      // Check if this is an asset link (images, etc.) - verify file exists on disk
+      if (isAssetLink(link.href)) {
+        if (!checkAssetLink(link.href)) {
+          brokenLinks.push({
+            href: link.href,
+            file: page.relativePath,
+            lines: [0],
+            text: link.text,
+          })
+        }
+        continue
+      }
+
       const normalized = normalizeLinkPath(link.href)
       const result = checkInternalLink(normalized, pageMap, redirects)
 
@@ -346,10 +364,14 @@ async function main() {
     console.log(`Created report issue: ${newReport.html_url}`)
   }
 
-  // Exit with error if broken links found
-  if (result.brokenLinks.length > 0) {
-    process.exit(1)
-  }
+  // Don't exit with error - the issue report is the mechanism for docs-content to act on broken links
+  // Exiting with error would trigger docs-alerts which only engineering monitors
+  console.log('')
+  console.log(
+    chalk.yellow(
+      'Note: Report generated. Broken links should be fixed via the issue created in docs-content.',
+    ),
+  )
 }
 
 // Run if invoked directly

src/links/scripts/check-links-pr.ts

@@ -24,6 +24,8 @@ import {
   extractLinksWithLiquid,
   createLiquidContext,
   checkInternalLink,
+  checkAssetLink,
+  isAssetLink,
   getRelativePath,
 } from '@/links/lib/extract-links'
 import { type BrokenLink, generatePRComment, groupBrokenLinks } from '@/links/lib/link-report'
@@ -74,6 +76,20 @@ async function checkFile(
   totalLinksChecked = internalLinks.length
 
   for (const link of internalLinks) {
+    // Check if this is an asset link (images, etc.) - verify file exists on disk
+    if (isAssetLink(link.href)) {
+      if (!checkAssetLink(link.href)) {
+        brokenLinks.push({
+          href: link.href,
+          file: getRelativePath(filePath),
+          lines: [link.line],
+          text: link.text,
+          isAutotitle: link.isAutotitle,
+        })
+      }
+      continue
+    }
+
     const result = checkInternalLink(link.href, pageMap, redirects)
 
     if (!result.exists) {

src/links/tests/extract-links.ts

@@ -3,6 +3,8 @@ import {
   extractLinksFromMarkdown,
   normalizeLinkPath,
   checkInternalLink,
+  checkAssetLink,
+  isAssetLink,
 } from '../lib/extract-links'
 
 describe('extractLinksFromMarkdown', () => {
@@ -209,3 +211,31 @@ describe('checkInternalLink', () => {
     expect(result.isRedirect).toBe(false)
   })
 })
+
+describe('isAssetLink', () => {
+  test('returns true for asset paths', () => {
+    expect(isAssetLink('/assets/images/help/test.png')).toBe(true)
+    expect(isAssetLink('/assets/cb-12345/images/help/test.png')).toBe(true)
+  })
+
+  test('returns false for non-asset paths', () => {
+    expect(isAssetLink('/actions/getting-started')).toBe(false)
+    expect(isAssetLink('/repositories/overview')).toBe(false)
+    expect(isAssetLink('https://example.com/assets/image.png')).toBe(false)
+  })
+})
+
+describe('checkAssetLink', () => {
+  test('returns true for existing asset files', () => {
+    // Use a known existing asset file
+    expect(checkAssetLink('/assets/images/help/writing/headings-rendered.png')).toBe(true)
+  })
+
+  test('returns false for non-existent asset files', () => {
+    expect(checkAssetLink('/assets/images/does-not-exist-12345.png')).toBe(false)
+  })
+
+  test('returns false for non-asset paths', () => {
+    expect(checkAssetLink('/actions/getting-started')).toBe(false)
+  })
+})

src/links/tests/link-report.ts

@@ -269,9 +269,9 @@ describe('generatePRComment', () => {
 
     const comment = generatePRComment(links)
 
-    expect(comment).toContain('Redirect')
-    expect(comment).toContain('`/old`')
-    expect(comment).toContain('`/new`')
+    // Redirects now show a compact summary with info icon
+    expect(comment).toContain('redirect')
+    expect(comment).toContain('ℹ️')
   })
 
   test('limits occurrences to 3 per group', () => {