Fix external link checker alert and wrong pat name (#59386)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: heiskr <1221423+heiskr@users.noreply.github.com>

Author: heiskr

.github/workflows/link-check-external.yml

@@ -42,18 +42,30 @@ jobs:
           fi
 
       - name: Upload report artifact
-        if: failure()
+        if: always()
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:
           name: external-link-report
           path: artifacts/external-link-report.*
           retention-days: 14
+          if-no-files-found: ignore
+
+      - name: Check if report exists
+        if: always()
+        id: check_report
+        run: |
+          if [ -f "artifacts/external-link-report.md" ]; then
+            echo "has_report=true" >> $GITHUB_OUTPUT
+          else
+            echo "has_report=false" >> $GITHUB_OUTPUT
+            echo "No broken link report generated - all links valid!"
+          fi
 
       - name: Create issue if broken links found
-        if: failure()
+        if: always() && steps.check_report.outputs.has_report == 'true'
         uses: peter-evans/create-issue-from-file@fca9117c27cdc29c6c4db3b86c48e4115a786710 # v5
         with:
-          token: ${{ secrets.DOCS_BOT_PAT_WORKFLOW }}
+          token: ${{ secrets.DOCS_BOT_PAT_BASE }}
           repository: github/docs-content
           title: '🌐 Broken External Links Report'
           content-filepath: artifacts/external-link-report.md

.github/workflows/link-check-internal.yml

@@ -78,7 +78,7 @@ jobs:
         if: matrix.language != 'en'
         uses: ./.github/actions/clone-translations
         with:
-          token: ${{ secrets.DOCS_BOT_PAT_READPUBLICKEY }}
+          token: ${{ secrets.DOCS_BOT_PAT_BASE }}
 
       - name: Check internal links
         env:
@@ -125,14 +125,14 @@ jobs:
           # Check if any reports exist
           if ls reports/*.md 1> /dev/null 2>&1; then
             echo "has_reports=true" >> $GITHUB_OUTPUT
-            
+
             # Combine all markdown reports
             echo "# Internal Links Report" > combined-report.md
             echo "" >> combined-report.md
             echo "Generated: $(date -u +'%Y-%m-%d %H:%M UTC')" >> combined-report.md
             echo "[Action run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})" >> combined-report.md
             echo "" >> combined-report.md
-            
+
             for report in reports/*.md; do
               echo "---" >> combined-report.md
               cat "$report" >> combined-report.md
@@ -147,7 +147,7 @@ jobs:
         if: steps.combine.outputs.has_reports == 'true'
         uses: peter-evans/create-issue-from-file@fca9117c27cdc29c6c4db3b86c48e4115a786710 # v5
         with:
-          token: ${{ secrets.DOCS_BOT_PAT_WORKFLOW }}
+          token: ${{ secrets.DOCS_BOT_PAT_BASE }}
           repository: github/docs-content
           title: '🔗 Broken Internal Links Report'
           content-filepath: combined-report.md

src/links/scripts/check-links-external.ts

@@ -356,9 +356,6 @@ async function main() {
 
     console.log(`Created report issue: ${newReport.html_url}`)
   }
-
-  // Exit with error if broken links found
-  process.exit(1)
 }
 
 // Run if invoked directly