Initial disable of domain name edit component (#54876)

Author: rachmari

src/fixtures/tests/playwright-rendering.spec.ts

@@ -797,59 +797,6 @@ test.describe('translations', () => {
   })
 })
 
-test.describe('domain edit', () => {
-  test('edit a domain (using header nav)', async ({ page }) => {
-    test.skip(true, 'Editing domain from header is disabled')
-
-    await page.goto('/')
-    await expect(page.getByText('Domain name:')).not.toBeVisible()
-    await page.getByLabel('Select GitHub product version').click()
-    await page
-      .getByLabel(/Enterprise Server/)
-      .first()
-      .click()
-    await expect(page.getByText('Domain name:')).toBeVisible()
-    await page.getByRole('button', { name: 'Edit' }).click()
-
-    await expect(page.getByTestId('domain-name-edit-form')).toBeVisible()
-    await expect(page.getByRole('heading', { name: 'Edit your domain name' })).toBeVisible()
-    await page.getByLabel('Your domain name', { exact: true }).fill('  github.com ')
-    await expect(page.getByText("Can't be github.com")).toBeVisible()
-    await page.getByLabel('Your domain name', { exact: true }).fill('github.peterbe.com ')
-    await expect(page.getByText("Can't be github.com")).not.toBeVisible()
-    await page.getByRole('button', { name: 'Save' }).click()
-
-    // This tests that the dialog is gone.
-    // XXX Peterbe: These don't work and I don't know why yet.
-    await expect(page.getByTestId('domain-name-edit-form')).not.toBeVisible()
-    await expect(page.getByText('github.peterbe.com')).toBeVisible()
-  })
-
-  test('edit a domain (clicking HOSTNAME)', async ({ page }) => {
-    await page.goto('/get-started/markdown/replace-domain')
-    await page.getByLabel('Select GitHub product version').click()
-    await page.getByLabel('Enterprise Server 3.12').click() // XXX
-
-    // This is generally discourage in Playwright, but necessary here
-    // in this case. Because of the way
-    // the `main.addEventListener('click', ...)` is handled, it's setting
-    // up that event listener too late. In fact, it happens in a useEffect.
-    // Adding a little delay makes is much more likely that the event
-    // listener has been set up my the time we fire the `.click()` on the
-    // next line.
-    await page.waitForTimeout(500)
-    await page.getByText('HOSTNAME', { exact: true }).first().click()
-
-    await expect(page.getByTestId('domain-name-edit-form')).toBeVisible()
-    await page
-      .getByTestId('domain-name-edit-form')
-      .getByLabel('Your domain name')
-      .fill('peterbe.ghe.com')
-    await page.getByTestId('domain-name-edit-form').getByLabel('Your domain name').press('Enter')
-    await expect(page.getByTestId('domain-name-edit-form')).not.toBeVisible()
-  })
-})
-
 test.describe('view pages with custom domain cookie', () => {
   test('view article page', async ({ page }) => {
     await page.goto(

src/frame/components/page-header/Header.tsx

@@ -1,9 +1,8 @@
-import { Suspense, useCallback, useEffect, useRef, useState } from 'react'
+import { useCallback, useEffect, useRef, useState } from 'react'
 import cx from 'classnames'
 import { useRouter } from 'next/router'
 import { Dialog, IconButton } from '@primer/react'
 import { MarkGithubIcon, ThreeBarsIcon } from '@primer/octicons-react'
-import dynamic from 'next/dynamic'
 
 import { DEFAULT_VERSION, useVersion } from 'src/versions/components/useVersion'
 import { Link } from 'src/frame/components/Link'
@@ -24,10 +23,6 @@ import { EXPERIMENTS } from '@/events/components/experiments/experiments'
 import { useShouldShowExperiment } from '@/events/components/experiments/useShouldShowExperiment'
 import { useQueryParam } from '@/frame/components/hooks/useQueryParam'
 
-const DomainNameEdit = dynamic(() => import('src/links/components/DomainNameEdit'), {
-  ssr: false,
-})
-
 export const Header = () => {
   const router = useRouter()
   const { error } = useMainContext()
@@ -134,8 +129,6 @@ export const Header = () => {
     homeURL += `/${currentVersion}`
   }
 
-  const showDomainNameEdit = currentVersion.startsWith('enterprise-server@')
-
   return (
     <div
       data-container="header"
@@ -176,14 +169,6 @@ export const Header = () => {
             <div className="hide-sm border-left pl-3">
               <VersionPicker />
             </div>
-
-            {showDomainNameEdit && (
-              <div className="hide-sm xborder-left pl-3">
-                <Suspense>
-                  <DomainNameEdit />
-                </Suspense>
-              </div>
-            )}
           </div>
           {showNewSearch ? (
             <HeaderSearchAndWidgets