Merge pull request #43386 from github/repo-sync

Repo sync

Author: docs-bot

.github/workflows/content-lint-markdown.yml

@@ -24,6 +24,9 @@ jobs:
     steps:
       - name: Check out repo
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        with:
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - name: Set up Node and dependencies
         uses: ./.github/actions/node-npm-setup

.github/workflows/link-check-on-pr.yml

@@ -30,6 +30,9 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        with:
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - uses: ./.github/actions/node-npm-setup
 

.github/workflows/readability.yml

@@ -27,10 +27,11 @@ jobs:
     if: github.repository == 'github/docs-internal'
     runs-on: ubuntu-latest
     steps:
-      - name: Check out repo with full history
+      - name: Check out repo
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
-          fetch-depth: 0
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - name: Checkout PR for manual dispatch
         if: ${{ github.event_name == 'workflow_dispatch' }}

.github/workflows/reviewers-legal.yml

@@ -33,6 +33,9 @@ jobs:
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6.0.1
+        with:
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - name: Get changed files
         id: changed_files

.github/workflows/test-changed-content.yml

@@ -28,6 +28,9 @@ jobs:
       # Even if if doesn't do anything
       - name: Check out repo
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        with:
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - uses: ./.github/actions/node-npm-setup
 

.github/workflows/test.yml

@@ -88,6 +88,9 @@ jobs:
       # Even if if doesn't do anything
       - name: Check out repo
         uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+        with:
+          # Fetch 2 commits so tj-actions/changed-files can diff without extra API calls
+          fetch-depth: 2
 
       - uses: ./.github/actions/setup-elasticsearch
         if: ${{ matrix.name == 'search' || matrix.name == 'languages' }}

config/kubernetes/default/deployments/webapp.yaml

@@ -25,6 +25,9 @@ spec:
             requests:
               cpu: 1000m
               memory: 4500Mi
+              # Keep ~600 MB headroom above --max-old-space-size in
+              # config/moda/configuration/default/env.yaml for Node
+              # off-heap memory and OS overhead.
             limits:
               cpu: 8000m
               memory: 16Gi

config/kubernetes/production/deployments/webapp.yaml

@@ -34,6 +34,9 @@ spec:
               # Absolute minimum to start app is 4500Mi
               # Would increase with more pages, versions, or languages supported
               # The additional memory helps during traffic surges
+              # Keep ~600 MB headroom above --max-old-space-size in
+              # config/moda/configuration/production/env.yaml for Node
+              # off-heap memory and OS overhead.
             limits:
               cpu: 16000m
               memory: 16Gi

config/moda/configuration/default/env.yaml

@@ -1,6 +1,12 @@
 data:
   MODA_APP_NAME: docs-internal
   NODE_ENV: production
+  # V8 heap limit (--max-old-space-size) should leave at least ~600 MiB
+  # below the K8s memory request for Node off-heap memory (Buffers,
+  # V8 code cache, libuv) and OS overhead. If you change the memory
+  # request in config/kubernetes/default/deployments/webapp.yaml,
+  # update this value to match.
+  # Current: 4500 MiB request, 4096 MiB heap = 404 MiB headroom
   NODE_OPTIONS: '--max-old-space-size=4096'
   PORT: '4000'
   ENABLED_LANGUAGES: 'en,es,ja,pt,zh,ru,fr,ko,de'

config/moda/configuration/production/env.yaml

@@ -1,6 +1,12 @@
 data:
   MODA_APP_NAME: docs-internal
   NODE_ENV: production
+  # V8 heap limit (--max-old-space-size) should leave at least ~600 MiB
+  # below the K8s memory request for Node off-heap memory (Buffers,
+  # V8 code cache, libuv) and OS overhead. If you change the memory
+  # request in config/kubernetes/production/deployments/webapp.yaml,
+  # update this value to match.
+  # Current: 8.0 Gi (8192 MiB) request, 7168 MiB heap = 1024 MiB headroom
   NODE_OPTIONS: '--max-old-space-size=7168'
   PORT: '4000'
   ENABLED_LANGUAGES: 'en,es,ja,pt,zh,ru,fr,ko,de'