Skip to content

Browser search string highlighting makes some text unreadable #45275

Description

@mcoker

Code of Conduct

What article on docs.github.com is affected?

I noticed this while searching for text in a .tsx file. In Chrome and Edge browsers, the named import text color is very close to the "current" syntax color. And in Firefox, the text is barely readable.

What changes are you suggesting?

The current search string text highlighting will have sufficient contrast so that the text is readable.

Additional information

Testing details

  • OS: MacOS Tahoe v26.5.2
  • Browsers
    • Chrome v150.0.7871.182
    • Edge v150.0.4078.96
    • Firefox v153.0
    • Safari showed sufficient contrast
  • Tested in dark theme using incognito for all browsers to disable any plugins/extensions. I was not logged in to GitHub for any of the tests.

To reproduce, go to https://github.com/github/docs/blob/main/src/app/layout.tsx and search for "ReactNode".

Here are screenshots of Chrome and Firefox

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    contentThis issue or pull request belongs to the Docs Content teamtriageDo not begin working on this issue until triaged by the team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions