Fix incorrect DNS instructions#37728
Conversation
The previous instructions incorrectly implied that users should choose _one_ of `A`, `AAAA` and `ALIAS`/`ANAME` records. In fact, if users do not opt for the `ALIAS`/`ANAME` record, they should use _both_ `A` and `AAAA` records. This change makes that clearer.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
This comment was marked as spam.
This comment was marked as spam.
|
Thanks for opening a PR! I'll get this triaged for review. |
|
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
...tom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md
Outdated
Show resolved
Hide resolved
…s-site/managing-a-custom-domain-for-your-github-pages-site.md
|
Okay, I got an SME review and it looks good. I'll add to the merge queue once checks are passing. 🎉 |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The previous instructions incorrectly implied that users should choose one of
A,AAAAandALIAS/ANAMErecords. In fact, if users do not opt for theALIAS/ANAMErecord, they should use bothAandAAAArecords. This change makes that clearer.(There is no issue for this change. I decided not to open one, because this is a minor change.)
What's being changed (if available, include any code snippets, screenshots, or gifs):
(This is trivially visible in the diff.)
Check off the following: