Conversation
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: heiskr <1221423+heiskr@users.noreply.github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This automated pull request synchronizes configuration and schema files between the public and private repositories.
- SHA values have been updated in several config files.
- Schema descriptions for alert filtering across multiple REST API versions have been updated.
- GraphQL schema fields for position parameters have been updated to be nullable with modified descriptions.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/webhooks/lib/config.json | Updated SHA value |
| src/rest/lib/config.json | Updated SHA value |
| src/rest/data/ghes-3.16-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/ghes-3.15-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/ghes-3.14-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/ghes-3.13-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/ghes-3.12-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/ghec-2022-11-28/schema.json | Updated alert filter descriptions |
| src/rest/data/fpt-2022-11-28/schema.json | Updated alert filter descriptions |
| src/graphql/data/ghec/schema.json | Changed GraphQL field types for “line” and “path” along with updated descriptions |
| src/graphql/data/ghec/schema.docs.graphql | Updated documentation for GraphQL “line” and “path” fields |
| src/graphql/data/fpt/schema.json | Changed GraphQL field types for “line” and “path” along with updated descriptions |
| src/graphql/data/fpt/schema.docs.graphql | Updated documentation for GraphQL “line” and “path” fields |
| src/graphql/data/fpt/changelog.json | Added changelog entries reflecting GraphQL schema changes |
| src/github-apps/lib/config.json | Updated SHA value |
Comments suppressed due to low confidence (4)
src/graphql/data/ghec/schema.json:102379
- Changing the field type from non-nullable (Int!) to nullable (Int) while the description indicates it is required may confuse API consumers. Consider ensuring consistency between the field type and its description.
"description": "<p>The line of the blob to which the thread refers. The end of the line range for\nmulti-line comments. Required if not using positioning.</p>",
src/graphql/data/ghec/schema.json:102387
- Changing the field type from non-nullable (String!) to nullable (String) while the description suggests it is required may cause confusion. Review the API contract to ensure clarity for consumers.
"description": "<p>Path to the file being commented on. Required if not using positioning.</p>",
src/graphql/data/fpt/schema.json:102379
- The change from a non-nullable type (Int!) to a nullable type (Int) for the line field, while its description implies it is required, might lead to integration issues. Validate whether the API should enforce non-nullability or adjust the documentation accordingly.
"description": "<p>The line of the blob to which the thread refers. The end of the line range for\nmulti-line comments. Required if not using positioning.</p>",
src/graphql/data/fpt/schema.json:102387
- Altering the type for the path field from String! to String, while the updated description marks it as required, may create uncertainty for API users. Consider aligning the type declaration with the stated requirement.
"description": "<p>Path to the file being commented on. Required if not using positioning.</p>",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.