Skip to content

Fix about-github-advanced-security.md#38563

Merged
Sharra-writes merged 2 commits intogithub:mainfrom
apc-sh-tanaka:patch-1
May 28, 2025
Merged

Fix about-github-advanced-security.md#38563
Sharra-writes merged 2 commits intogithub:mainfrom
apc-sh-tanaka:patch-1

Conversation

@apc-sh-tanaka
Copy link
Copy Markdown
Contributor

@apc-sh-tanaka apc-sh-tanaka commented May 28, 2025

about features with GitHub Code Security

Why:

Closes: #38562

What's being changed (if available, include any code snippets, screenshots, or gifs):

fix about features with GitHub Code Security

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@apc-sh-tanaka
Update about-github-advanced-security.md
02bd295 
about features with GitHub Code Security
Copilot AI review requested due to automatic review settings May 28, 2025 09:54
Copilot AI reviewed May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the table in the GitHub Advanced Security documentation to ensure that the proper product variable is used for public repositories.

  • Updates the variable in the public repository column to consistently use {% data variables.product.prodname_GH_code_security %}.
  • Aligns the table content with the intended documentation for GitHub Code Security.

content/get-started/learning-about-github/about-github-advanced-security.md
{% rowheaders %}

| | Public repository <br>without {% data variables.product.prodname_GH_secret_protection %} | Private repository <br>without {% data variables.product.prodname_GH_code_security %} | Public or private repository <br>with {% data variables.product.prodname_GH_code_security %} |
| | Public repository <br>without {% data variables.product.prodname_GH_code_security %} | Private repository <br>without {% data variables.product.prodname_GH_code_security %} | Public or private repository <br>with {% data variables.product.prodname_GH_code_security %} |
Copy link

Copilot AI May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that replacing {% data variables.product.prodname_GH_secret_protection %} with {% data variables.product.prodname_GH_code_security %} for the public repository column is intentional and aligns with the intended documentation for GitHub Advanced Security.

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025 •
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
get-started/learning-about-github/about-github-advanced-security.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

YIN403 referenced this pull request May 28, 2025
@nguyenalex836 @subatoi
@Michael21107 @heiskr
Update PULL_REQUEST_TEMPLATE.md (#54040)
0ce65af 
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
Co-authored-by: Michael21107 <121039033+Michael21107@users.noreply.github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
@Sharra-writes
Copy link
Copy Markdown
Contributor

Sharra-writes commented May 28, 2025

That definitely looks like the wrong variable was referenced in that table! I'll get this approved and added to the merge queue once checks are passing. 👍

@Sharra-writes Sharra-writes added this pull request to the merge queue May 28, 2025
Merged via the queue into github:main with commit 6e19bb8 May 28, 2025
42 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Sharra-writes Sharra-writes Sharra-writes approved these changes

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

misprint about features with GitHub Code Security

3 participants

@apc-sh-tanaka @Sharra-writes