Skip to content

Node24#287

Merged
robandpdx merged 2 commits into
mainfrom
node24
May 28, 2026
Merged

Node24#287
robandpdx merged 2 commits into
mainfrom
node24

Conversation

@robandpdx

@robandpdx robandpdx commented May 28, 2026

Copy link
Copy Markdown
Collaborator

This pull request upgrades the project environment and dependencies to Node.js 24 and Debian Trixie, updates the AWS Lambda runtime, and ensures compatibility with newer Python packaging standards. It also standardizes the use of a custom Octokit instance with a specific GitHub API version header across both production and test code.

Environment and Dependency Upgrades:

  • Upgraded the development container to use Node.js 24 and Debian Trixie by updating the VARIANT argument in .devcontainer/Dockerfile and .devcontainer/devcontainer.json. [1] [2]
  • Updated GitHub Actions workflows to use Node.js version 24 for both PR and test pipelines. [1] [2]
  • Changed the AWS Lambda runtime in template.yml from nodejs20.x to nodejs24.x to match the new Node.js version.

Python and AWS SAM CLI Installation:

  • Modified the devcontainer setup to install Python 3, python-is-python3, python3-pip, and pipx instead of legacy Python packages, and now installs aws-sam-cli via pipx to comply with Debian Trixie’s PEP 668 externally-managed environment. [1] [2]

GitHub API Versioning and Octokit Configuration:

  • Updated both handler.js and test setup to use a custom Octokit instance with a user agent and the X-GitHub-Api-Version: 2026-03-10 header, ensuring consistent API versioning in production and tests. [1] [2]

Copilot AI review requested due to automatic review settings May 28, 2026 19:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the project's Node.js runtime from 20 to 24 across CI workflows, the AWS Lambda deployment template, the dev container, and adds an explicit X-GitHub-Api-Version header (2026-03-10) for both production and test Octokit instances.

Changes:

  • Bump Node.js to 24 in CI workflows, SAM template (nodejs24.x), and devcontainer (variant 24-trixie, switched to python3/pipx for SAM CLI install).
  • Configure a custom Octokit in handler.js (and test setup) with a user agent and pinned X-GitHub-Api-Version: 2026-03-10 header.
Show a summary per file
File Description
.github/workflows/test.yml Updates Node version in test workflow to 24.
.github/workflows/pr.yml Updates Node version in PR workflow to 24.
template.yml Switches Lambda runtime to nodejs24.x.
.devcontainer/Dockerfile Uses 24-trixie base image and adapts SAM CLI install to use pipx for PEP 668 compliance.
.devcontainer/devcontainer.json Updates VARIANT build arg to 24-trixie.
handler.js Creates a customized ProbotOctokit with user agent and pinned API version, passed via createProbot overrides.
test.js Adds the matching X-GitHub-Api-Version header on the test ProbotOctokit defaults.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 7/7 changed files
  • Comments generated: 0

@github-actions

Copy link
Copy Markdown
Contributor

=============================== Coverage summary ===============================
Statements   : 100% ( 166/166 )
Branches     : 100% ( 102/102 )
Functions    : 100% ( 28/28 )
Lines        : 100% ( 164/164 )
================================================================================

@robandpdx robandpdx merged commit c95bc55 into main May 28, 2026
6 checks passed
@robandpdx robandpdx deleted the node24 branch May 28, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants