Fix rubocop freakouts

Rubocop was unhappy with the `save_api_cache!` and `load_api_cache!` methods introduced in #5042 - some were legit problems but it had spurious errors around method length and Cyclomatic Complexity, which are not worth fixing.

Author: ahpook

.rubocop.yml

@@ -32,3 +32,19 @@ Style/TrailingCommaInArrayLiteral:
 
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
+
+Metrics/AbcSize:
+  Exclude:
+    - 'test/test_helper.rb'
+
+Metrics/MethodLength:
+  Exclude:
+    - 'test/test_helper.rb'
+
+Metrics/CyclomaticComplexity:
+  Exclude:
+    - 'test/test_helper.rb'
+
+Metrics/PerceivedComplexity:
+  Exclude:
+    - 'test/test_helper.rb'

test/test_helper.rb

@@ -280,44 +280,40 @@ def load_api_cache!
   now = Time.now.to_i
   ttl = CACHE_TTL_SECONDS
 
-  if data["repos"]
-    data["repos"].each do |key, entry|
-      cached_at = entry["cached_at"]
-      next unless cached_at
-      next if now - cached_at.to_i > ttl
-
-      result = entry["value"]
-      # Reconstruct a minimal object that responds to .full_name
-      cached = if result.nil?
-                 nil
-               else
-                 next unless result["full_name"]
-
-                 Struct.new(:full_name).new(result["full_name"])
-               end
-      NewOctokit.class_variable_get(:@@repos)[key] = cached
-    end
+  data["repos"]&.each do |key, entry|
+    cached_at = entry["cached_at"]
+    next unless cached_at
+    next if now - cached_at.to_i > ttl
+
+    result = entry["value"]
+    # Reconstruct a minimal object that responds to .full_name
+    cached = if result.nil?
+               nil
+             else
+               next unless result["full_name"]
+
+               Struct.new(:full_name).new(result["full_name"])
+             end
+    NewOctokit.class_variable_get(:@@repos)[key] = cached
   end
 
-  if data["users"]
-    data["users"].each do |key, entry|
-      cached_at = entry["cached_at"]
-      next unless cached_at
-      next if now - cached_at.to_i > ttl
-
-      result = entry["value"]
-      cached = if result.nil?
-                 nil
-               else
-                 next unless result["login"]
-
-                 Struct.new(:login).new(result["login"])
-               end
-      NewOctokit.class_variable_get(:@@users)[key] = cached
-    end
+  data["users"]&.each do |key, entry|
+    cached_at = entry["cached_at"]
+    next unless cached_at
+    next if now - cached_at.to_i > ttl
+
+    result = entry["value"]
+    cached = if result.nil?
+               nil
+             else
+               next unless result["login"]
+
+               Struct.new(:login).new(result["login"])
+             end
+    NewOctokit.class_variable_get(:@@users)[key] = cached
   end
-rescue JSON::ParserError, StandardError => e
-  warn "Failed to load API cache: #{e.message}"
+rescue StandardError => error
+  warn "Failed to load API cache: #{error.message}"
 end
 
 def save_api_cache!
@@ -331,7 +327,11 @@ def save_api_cache!
 
     repos_data[key.to_s] = {
       "cached_at" => now,
-      "value" => value.nil? ? nil : { "full_name" => value.respond_to?(:full_name) ? value.full_name : value.to_s },
+      "value" => if value.nil?
+                   nil
+                 else
+                   { "full_name" => value.respond_to?(:full_name) ? value.full_name : value.to_s }
+                 end,
     }
   end
 
@@ -341,13 +341,17 @@ def save_api_cache!
 
     users_data[key.to_s] = {
       "cached_at" => now,
-      "value" => value.nil? ? nil : { "login" => value.respond_to?(:login) ? value.login : value.to_s },
+      "value" => if value.nil?
+                   nil
+                 else
+                   { "login" => value.respond_to?(:login) ? value.login : value.to_s }
+                 end,
     }
   end
 
   File.write(CACHE_FILE, JSON.pretty_generate({ "repos" => repos_data, "users" => users_data }))
-rescue StandardError => e
-  warn "Failed to save API cache: #{e.message}"
+rescue StandardError => error
+  warn "Failed to save API cache: #{error.message}"
 end
 
 # Load cached API results at startup