Skip to content

Parallelize collection tests into 4 shards #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahpook merged 4 commits into from
Mar 14, 2026
Merged

Parallelize collection tests into 4 shards #5041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c47b44b
Parallelize collection tests into 4 shards
kenyonj Feb 13, 2026
198d465
Use explicit nil checks for shard variables
kenyonj Feb 13, 2026
59b379b
Merge branch 'main' into parallelize-collection-tests
tomthorogood Mar 10, 2026
cf134a9
Merge branch 'main' into parallelize-collection-tests
ahpook Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,21 @@ jobs:
strategy:
fail-fast: false
matrix:
test_type:
- collections
- topics
- all
include:
- test_type: topics
- test_type: collections
shard: 0
total_shards: 4
- test_type: collections
shard: 1
total_shards: 4
- test_type: collections
shard: 2
total_shards: 4
- test_type: collections
shard: 3
total_shards: 4
- test_type: all
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6.0.1
Expand Down Expand Up @@ -58,3 +69,5 @@ jobs:
TOPIC_FILES: ${{ steps.topics.outputs.changed }}
COLLECTION_FILES: ${{ steps.collections.outputs.changed }}
TEST_ALL_FILES: ${{ steps.all.outputs.changed }}
COLLECTION_SHARD: ${{ matrix.shard }}
COLLECTION_TOTAL_SHARDS: ${{ matrix.total_shards }}
14 changes: 13 additions & 1 deletion test/collections_test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,19 @@ def dirs_to_test
end

def collections
collection_dirs.map { |dir_path| File.basename(dir_path) }
all = collection_dirs.map { |dir_path| File.basename(dir_path) }
shard_collections(all)
end

def shard_collections(all_collections)
shard = ENV["COLLECTION_SHARD"]&.to_i
total_shards = ENV["COLLECTION_TOTAL_SHARDS"]&.to_i

return all_collections unless shard && total_shards && total_shards > 1
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition shard && total_shards && total_shards > 1 will fail when shard is 0 because 0 is falsy in Ruby. This means shard 0 (the first shard in the matrix) will incorrectly test all collections instead of just every 4th collection starting at index 0. The condition should check for nil explicitly instead: !shard.nil? && !total_shards.nil? && total_shards > 1.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@kenyonj kenyonj Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 198d465 — switched to explicit nil checks: !shard.nil? && !total_shards.nil? && total_shards > 1. This also avoids the falsy-zero bug for shard 0. Thanks for the catch!


# Sort alphabetically for deterministic sharding
sorted = all_collections.sort
sorted.select.with_index { |_, i| i % total_shards == shard }
end

def items_for_collection(collection)
Expand Down
Loading