Update GitHub Actions workflow for npm publishing#56
Open
gracepark wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the npm publishing GitHub Actions workflow to use newer GitHub Actions versions and attempt to publish to npm with provenance enabled.
Changes:
- Bumps
actions/checkoutandactions/setup-nodefromv3tov4. - Updates the publishing job to use Node.js 24 and grants
id-token: writepermissions. - Switches the publish command to
npm publish --provenanceand removes token-based auth wiring.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Modernizes the release publish workflow and changes the publish/auth approach to support provenance. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
.github/workflows/publish.yml:25
- The publish step no longer supplies npm authentication (previously via NODE_AUTH_TOKEN secret). As written,
npm publishwill fail with an auth error unless npm Trusted Publishing (OIDC-based) is configured for this package on npmjs. If Trusted Publishing is intended, consider adding an explicit note/validation step (e.g.,npm whoami) so failures are clearer; otherwise reintroduce token-based auth for the publish command.
- run: npm version ${TAG_NAME} --git-tag-version=false
env:
TAG_NAME: ${{ github.event.release.tag_name }}
- run: npm --ignore-scripts publish --provenance
.github/workflows/publish.yml:18
node-version: 24is unquoted and differs from the semver-style string used elsewhere in this repo (e.g.'20.x'). Using a quoted semver range like'24.x'avoids YAML type coercion and makes intent consistent with other workflows.
with:
node-version: 24
registry-url: https://registry.npmjs.org/
- Files reviewed: 1/1 changed files
- Comments generated: 1
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309