-
Notifications
You must be signed in to change notification settings - Fork 37
Expand file tree
/
Copy pathworkdir-setup.test.ts
More file actions
340 lines (262 loc) · 12.2 KB
/
Copy pathworkdir-setup.test.ts
File metadata and controls
340 lines (262 loc) · 12.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
import * as fs from 'fs';
import * as os from 'os';
import * as path from 'path';
// eslint-disable-next-line @typescript-eslint/no-require-imports
jest.mock('fs', () => require('./test-helpers/fs-mock-factory.test-utils').fsMockFactory());
// eslint-disable-next-line @typescript-eslint/no-require-imports
jest.mock('./host-env', () => require('./test-helpers/fs-mock-factory.test-utils').hostEnvMockFactory());
// eslint-disable-next-line @typescript-eslint/no-require-imports
jest.mock('./host-identity', () => require('./test-helpers/fs-mock-factory.test-utils').hostIdentityMockFactory());
import { prepareWorkDirectories, workdirSetupTestHelpers } from './workdir-setup';
import { resolveLogPaths } from './log-paths';
import { getRealUserHome } from './host-identity';
function setupWorkdirFixture({ cleanupChrootHome = true } = {}) {
let tempDir = '';
const buildConfig = (overrides: Record<string, unknown> = {}) => ({
workDir: tempDir,
sslBump: false,
allowedDomains: [] as string[],
agentCommand: 'echo test',
logLevel: 'info' as const,
keepContainers: false,
buildLocal: false,
imageRegistry: 'ghcr.io/github/gh-aw-firewall',
imageTag: 'latest',
...overrides,
});
beforeEach(() => {
tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'workdir-setup-test-'));
jest.clearAllMocks();
(fs.chownSync as unknown as jest.Mock).mockImplementation(() => undefined);
(getRealUserHome as jest.Mock).mockReturnValue(tempDir);
});
afterEach(() => {
if (!tempDir) {
return;
}
fs.rmSync(tempDir, { recursive: true, force: true });
if (cleanupChrootHome) {
fs.rmSync(`${tempDir}-chroot-home`, { recursive: true, force: true });
}
});
return {
buildConfig,
get tempDir() {
return tempDir;
},
};
}
describe('prepareWorkDirectories', () => {
const fixture = setupWorkdirFixture();
const { buildConfig } = fixture;
describe('log/state directory setup', () => {
it('creates agent logs directory', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(logPaths.agentLogs)).toBe(true);
expect(fs.statSync(logPaths.agentLogs).isDirectory()).toBe(true);
});
it('creates session-state directory', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(logPaths.sessionState)).toBe(true);
expect(fs.statSync(logPaths.sessionState).isDirectory()).toBe(true);
});
it('creates squid logs directory', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(logPaths.squidLogs)).toBe(true);
expect(fs.statSync(logPaths.squidLogs).isDirectory()).toBe(true);
});
it('creates api-proxy logs directory', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(logPaths.apiProxyLogs)).toBe(true);
expect(fs.statSync(logPaths.apiProxyLogs).isDirectory()).toBe(true);
});
it('creates cli-proxy logs directory', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(logPaths.cliProxyLogs)).toBe(true);
expect(fs.statSync(logPaths.cliProxyLogs).isDirectory()).toBe(true);
});
it('creates /tmp/gh-aw/mcp-logs with mode 0o777', () => {
const mcpLogsDir = '/tmp/gh-aw/mcp-logs';
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(mcpLogsDir)).toBe(true);
const mode = fs.statSync(mcpLogsDir).mode & 0o777;
expect(mode).toBe(0o777);
});
it('forces pre-existing mcp logs directory to mode 0o777', () => {
const mcpLogsDir = '/tmp/gh-aw/mcp-logs';
fs.mkdirSync(mcpLogsDir, { recursive: true, mode: 0o700 });
fs.chmodSync(mcpLogsDir, 0o700);
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
const mode = fs.statSync(mcpLogsDir).mode & 0o777;
expect(mode).toBe(0o777);
});
it('falls back to world-writable squid logs when squid chown fails', () => {
const proxyLogsDir = path.join(fixture.tempDir, 'proxy-logs');
(fs.chownSync as unknown as jest.Mock).mockImplementation((targetPath: fs.PathLike) => {
if (String(targetPath) === proxyLogsDir) {
throw new Error('chown failed');
}
});
const config = buildConfig({ proxyLogsDir });
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
const mode = fs.statSync(proxyLogsDir).mode & 0o777;
expect(mode).toBe(0o777);
});
});
describe('chroot home bind-mount preparation', () => {
it('creates chroot home directory when it does not exist', () => {
const emptyHomeDir = `${fixture.tempDir}-chroot-home`;
expect(fs.existsSync(emptyHomeDir)).toBe(false);
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(emptyHomeDir)).toBe(true);
expect(fs.statSync(emptyHomeDir).isDirectory()).toBe(true);
});
it('uses existing chroot home directory if already present', () => {
const emptyHomeDir = `${fixture.tempDir}-chroot-home`;
fs.mkdirSync(emptyHomeDir, { recursive: true });
const statBefore = fs.statSync(emptyHomeDir);
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
const statAfter = fs.statSync(emptyHomeDir);
expect(statAfter.ino).toBe(statBefore.ino);
});
it('creates missing home subdirectories with correct ownership', () => {
const copilotDir = path.join(fixture.tempDir, '.copilot');
if (fs.existsSync(copilotDir)) {
fs.rmSync(copilotDir, { recursive: true, force: true });
}
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(copilotDir)).toBe(true);
expect(fs.chownSync).toHaveBeenCalledWith(copilotDir, 1000, 1000);
});
it('creates .gemini directory when geminiApiKey is provided', () => {
const geminiDir = path.join(fixture.tempDir, '.gemini');
if (fs.existsSync(geminiDir)) {
fs.rmSync(geminiDir, { recursive: true, force: true });
}
const config = buildConfig({ geminiApiKey: 'test-key' });
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(geminiDir)).toBe(true);
});
it('does not create .gemini directory when geminiApiKey is not provided', () => {
const geminiDir = path.join(fixture.tempDir, '.gemini');
if (fs.existsSync(geminiDir)) {
fs.rmSync(geminiDir, { recursive: true, force: true });
}
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(geminiDir)).toBe(false);
});
it('creates configured runner tool cache directory segments with correct ownership', () => {
const runnerToolCacheParent = path.join(fixture.tempDir, 'runner-work');
const runnerToolCachePath = path.join(runnerToolCacheParent, '_tool');
expect(fs.existsSync(runnerToolCachePath)).toBe(false);
const config = buildConfig({ runnerToolCachePath });
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
expect(fs.existsSync(runnerToolCachePath)).toBe(true);
expect(fs.statSync(runnerToolCachePath).isDirectory()).toBe(true);
expect(fs.chownSync).toHaveBeenCalledWith(runnerToolCacheParent, 1000, 1000);
expect(fs.chmodSync).toHaveBeenCalledWith(runnerToolCacheParent, 0o755);
expect(fs.chownSync).toHaveBeenCalledWith(runnerToolCachePath, 1000, 1000);
expect(fs.chmodSync).toHaveBeenCalledWith(runnerToolCachePath, 0o755);
});
it('throws when runnerToolCachePath contains a pre-existing non-root-owned intermediate symlink', () => {
const realDir = path.join(fixture.tempDir, 'real-dir');
const symlinkDir = path.join(fixture.tempDir, 'link-to-real');
fs.mkdirSync(realDir, { recursive: true });
fs.symlinkSync(realDir, symlinkDir);
const runnerToolCachePath = path.join(symlinkDir, 'child');
const config = buildConfig({ runnerToolCachePath });
const logPaths = resolveLogPaths(config);
expect(() => prepareWorkDirectories(config, logPaths)).toThrow(
`Refusing to use symlink as directory: ${symlinkDir}`
);
});
it('prepares chroot mountpoint for fallback runner tool cache under home', () => {
const runnerToolCachePath = path.join(fixture.tempDir, 'work', '_tool');
fs.mkdirSync(runnerToolCachePath, { recursive: true });
const savedRunnerToolCache = process.env.RUNNER_TOOL_CACHE;
delete process.env.RUNNER_TOOL_CACHE;
try {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
prepareWorkDirectories(config, logPaths);
} finally {
if (savedRunnerToolCache !== undefined) {
process.env.RUNNER_TOOL_CACHE = savedRunnerToolCache;
}
}
const chrootWorkDir = path.join(`${fixture.tempDir}-chroot-home`, 'work');
const chrootToolCacheDir = path.join(chrootWorkDir, '_tool');
expect(fs.existsSync(chrootToolCacheDir)).toBe(true);
expect(fs.statSync(chrootToolCacheDir).isDirectory()).toBe(true);
expect(fs.chownSync).toHaveBeenCalledWith(chrootWorkDir, 1000, 1000);
expect(fs.chmodSync).toHaveBeenCalledWith(chrootWorkDir, 0o755);
expect(fs.chownSync).toHaveBeenCalledWith(chrootToolCacheDir, 1000, 1000);
expect(fs.chmodSync).toHaveBeenCalledWith(chrootToolCacheDir, 0o755);
});
});
});
describe('prepareLogDirectories (sub-function)', () => {
const fixture = setupWorkdirFixture({ cleanupChrootHome: false });
const { buildConfig } = fixture;
it('creates all log directories without touching chroot home', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
workdirSetupTestHelpers.prepareLogDirectories(logPaths);
expect(fs.existsSync(logPaths.agentLogs)).toBe(true);
expect(fs.existsSync(logPaths.sessionState)).toBe(true);
expect(fs.existsSync(logPaths.squidLogs)).toBe(true);
expect(fs.existsSync(logPaths.apiProxyLogs)).toBe(true);
expect(fs.existsSync(logPaths.cliProxyLogs)).toBe(true);
// chroot home must NOT have been created
expect(fs.existsSync(`${fixture.tempDir}-chroot-home`)).toBe(false);
});
});
describe('prepareChrootHomeMounts (sub-function)', () => {
const fixture = setupWorkdirFixture();
const { buildConfig } = fixture;
it('creates chroot home directory without touching log directories', () => {
const config = buildConfig();
const logPaths = resolveLogPaths(config);
workdirSetupTestHelpers.prepareChrootHomeMounts(config);
expect(fs.existsSync(`${fixture.tempDir}-chroot-home`)).toBe(true);
// log directories must NOT have been created
expect(fs.existsSync(logPaths.agentLogs)).toBe(false);
expect(fs.existsSync(logPaths.sessionState)).toBe(false);
expect(fs.existsSync(logPaths.squidLogs)).toBe(false);
expect(fs.existsSync(logPaths.apiProxyLogs)).toBe(false);
expect(fs.existsSync(logPaths.cliProxyLogs)).toBe(false);
});
it('creates .gemini directory only when geminiApiKey is provided', () => {
const geminiDir = path.join(fixture.tempDir, '.gemini');
workdirSetupTestHelpers.prepareChrootHomeMounts(buildConfig({ geminiApiKey: 'key' }));
expect(fs.existsSync(geminiDir)).toBe(true);
fs.rmSync(geminiDir, { recursive: true, force: true });
workdirSetupTestHelpers.prepareChrootHomeMounts(buildConfig());
expect(fs.existsSync(geminiDir)).toBe(false);
});
});