Skip to content

Commit 10d3a2e

Browse files
lpcoxCopilotCopilot
authored
fix(smoke-claude): raise turn budget to 8 and fix add_comment usage (#5328)
* fix(smoke-claude): raise turn budget to 8 and fix add_comment usage The Smoke Claude job was failing with "403 Maximum LLM invocations exceeded (5 / 5)". The agent burned one of only five api-proxy runs on an empty-args `add_comment` schema probe (`safeoutputs add_comment .` with JSON piped via stdin yields `args: {}`, rejected by MCP), and the cumulative cap left no room to retry. Two-pronged fix: - Raise `max-turns` 5 -> 8 for headroom (expands to --max-turns, GH_AW_MAX_TURNS, and apiProxy maxRuns). - Add explicit prompt guidance to pass `add_comment` arguments inline as a single JSON object and never pipe JSON via stdin or pass `.`. Recompiled the lock and re-ran the smoke post-processing script. Updated smoke-claude-workflow.test.ts assertions accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: address smoke claude review feedback --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 parent 29f8e2a commit 10d3a2e

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

.github/workflows/smoke-claude.lock.yml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-claude.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ permissions:
1515
pull-requests: read
1616

1717
name: Smoke Claude
18-
max-turns: 5
18+
max-turns: 8
1919
engine:
2020
id: claude
2121
model: claude-haiku-4-5
@@ -150,6 +150,7 @@ All data is pre-computed. Read `/tmp/gh-aw/agent/final-result.json` (one bash ca
150150
The JSON contains: `result` (PASS/FAIL), `api_status`, `gh_check`, `file_status`, `event`, `pr_number`.
151151

152152
- If `event` is `pull_request`: call `add_comment` with `item_number` set to `pr_number` and a body listing each check result plus the overall `result`; then call `add_labels` with `["smoke-claude"]` only if `result` is `PASS`.
153+
- Pass arguments inline as a single JSON object, e.g. `safeoutputs add_comment '{"item_number": 123, "body": "Smoke Claude result: PASS"}'`. Do NOT pipe JSON via stdin and do NOT pass `.` (or any placeholder) as the argument — that sends empty arguments and the call is rejected as a schema probe, wasting a turn.
153154
- Never call `add_comment` or `add_labels` with empty arguments or as a schema probe. Use explicit arguments only.
154155
- Otherwise: call `noop` with the result summary.
155156

0 commit comments

Comments
 (0)