Skip to content

Commit 12ecabd

Browse files
authored
fix: harden smoke-claude safe output instructions
1 parent 84e1ff3 commit 12ecabd

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/smoke-claude.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ Your tasks (1 line per result):
125125
3. **File verify**: Confirm file exists at `/tmp/gh-aw/agent/smoke-test-claude-${{ github.run_id }}.txt`
126126

127127
Call safe-outputs immediately after these 3 reads.
128+
- Call tools directly (`add_comment`, `add_labels`, `noop`) — do not run `safeoutputs ...` via Bash/CLI.
129+
- Never call `add_comment` or `add_labels` with empty arguments. If you're not ready to send final output, call `noop` with a short message.
128130

129131
**If triggered by pull request**: add a brief comment (✅/❌ per test, PASS/FAIL total) and add label `smoke-claude` if all pass.
130132
**If not triggered by pull request**: use noop to report results.

scripts/ci/smoke-claude-workflow.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ describe('smoke claude workflow optimization config', () => {
1616
expect(source).not.toContain("grep -oP '(?<=<title>)[^<]+'");
1717
expect(source).toContain('> "$CONTEXT_FILE"');
1818
expect(source).toContain('**IMPORTANT — Complete in 1 pass:**');
19+
expect(source).toContain('do not run `safeoutputs ...` via Bash/CLI');
20+
expect(source).toContain('Never call `add_comment` or `add_labels` with empty arguments');
1921
expect(source).not.toContain('tools:\n playwright:');
2022
expect(source).not.toContain(' - playwright');
2123
expect(source).not.toContain('Ensure playwright log directory is writable');

0 commit comments

Comments
 (0)