Skip to content

Commit e5517e4

Browse files
CopilotMossaka
andauthored
docs: add security scope restriction info to AGENTS.md (#301)
* Initial plan * docs: add security scope restriction info to AGENTS.md Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
1 parent 74d4fa3 commit e5517e4

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

AGENTS.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,10 @@ This downloads artifacts to `./artifacts-run-$RUN_ID` for local examination. Req
9090
- PR descriptions should be 1-2 sentences max
9191

9292
**Allowed scopes for PR titles:** `cli`, `docker`, `squid`, `proxy`, `ci`, `deps`
93-
- Using scopes not in this list will cause the PR Title Check to fail
94-
- If unsure, omit the scope entirely (e.g., `test: add new tests` instead of `test(security): add new tests`)
93+
- Using scopes not in this list will cause the PR Title Check to fail with an error like:
94+
`Error: Unknown scope "security" found in pull request title. Scope must match one of: cli, docker, squid, proxy, ci, deps.`
95+
- Common invalid scopes: `security`, `test`, `docs`, `core` - these are NOT allowed as scopes
96+
- If unsure, omit the scope entirely (e.g., `fix: replace .* regex with safer patterns` instead of `fix(security): replace .* regex with safer patterns`)
9597

9698
**Common types:**
9799
- `feat`: New feature
@@ -107,9 +109,11 @@ This downloads artifacts to `./artifacts-run-$RUN_ID` for local examination. Req
107109
- ✅ `docs(template): fix duplicate heading in release template`
108110
- ✅ `feat: add new domain whitelist option`
109111
- ✅ `fix(cleanup): resolve container cleanup race condition`
112+
- ✅ `fix: replace .* regex with safer patterns` (no scope - preferred for security fixes)
110113
- ✅ `test: add NET_ADMIN capability verification tests`
111114
- ❌ `Fix bug` (missing type)
112115
- ❌ `docs: Fix template.` (uppercase subject, period at end)
116+
- ❌ `fix(security): replace .* regex with safer patterns` (scope `security` not in allowed list)
113117
- ❌ `test(security): add new tests` (scope `security` not in allowed list for PR titles)
114118

115119
## Development Commands

0 commit comments

Comments
 (0)