Skip to content

Remove unused export from SslBumpConfig in security-critical module #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 4 commits into from
May 3, 2026
Merged

Remove unused export from SslBumpConfig in security-critical module #2438

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b1f07e
Initial plan
Copilot May 3, 2026
4943e68
fix: remove unused export from SslBumpConfig interface in ssl-bump.ts
Copilot May 3, 2026
8258b96
fix: inline SslBumpConfig parameter type to fix declaration emit with…
Copilot May 3, 2026
a30c75c
fix: remove unused SslBumpConfig interface to fix ESLint no-unused-va…
Copilot May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/ssl-bump.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ export function chownRecursive(dirPath: string, uid: number, gid: number): void
}
}

/**
* Configuration for SSL Bump CA generation
*/
export interface SslBumpConfig {
/** Working directory to store CA files */
workDir: string;
/** Common name for the CA certificate (default: 'AWF Session CA') */
commonName?: string;
/** Validity period in days (default: 1) */
validityDays?: number;
}

/**
* Result of CA generation containing paths to certificate files
*/
Expand Down Expand Up @@ -178,7 +166,7 @@ export function cleanupSslKeyMaterial(workDir: string): void {
* @returns Paths to generated CA files
* @throws Error if OpenSSL commands fail
*/
export async function generateSessionCa(config: SslBumpConfig): Promise<CaFiles> {
export async function generateSessionCa(config: { workDir: string; commonName?: string; validityDays?: number }): Promise<CaFiles> {
const { workDir, commonName = 'AWF Session CA', validityDays = 1 } = config;

// Create ssl directory in workDir, backed by tmpfs when possible
Expand Down
Loading