Codex: remove openai-proxy env_key requirement in postprocessed lock workflows#3234
Conversation
openai-proxy env_key requirement in postprocessed lock workflows
There was a problem hiding this comment.
Pull request overview
Removes the env_key = "OPENAI_API_KEY" requirement from the Codex openai-proxy provider config emitted by the smoke workflow postprocessor, since auth is handled by the AWF sidecar and forcing an env var caused Codex startup failures in the sandbox.
Changes:
- Stop emitting
env_keywhen injecting theopenai-proxyprovider block inpostprocess-smoke-workflows.ts, and add a regex transform that strips legacyenv_keylines from existing blocks. - Regenerate Codex lock workflows to drop the
env_keyline. - Add Jest coverage for both the injection (no
env_key) and legacy-removal cases.
Show a summary per file
| File | Description |
|---|---|
| scripts/ci/postprocess-smoke-workflows.ts | Drop env_key from injected provider block; add compatibility regex to strip legacy lines. |
| scripts/ci/postprocess-smoke-workflows.test.ts | Add tests asserting injection omits env_key and legacy env_key is stripped. |
| .github/workflows/smoke-codex.lock.yml | Regenerated lock file with env_key removed. |
| .github/workflows/secret-digger-codex.lock.yml | Regenerated lock file with env_key removed in two provider blocks. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
Smoke Test Results
Summary: 2/3 PASS — Playwright and file tests passed. GitHub API test requires gh CLI authentication in this environment.
|
Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: FAIL — pre-step template variables were not substituted; GitHub MCP returned 401.
|
🔬 Smoke Test Results
Overall: FAIL — GitHub MCP auth unavailable; workflow template variables were not expanded at runtime.
|
|
Smoke test: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Gemini Engine Smoke Test Results
Overall Status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Codex runs routed through the AWF OpenAI proxy were failing at startup because generated provider config required
OPENAI_API_KEY, while the sandbox intentionally excludes real OpenAI/Codex keys. This change removes that hard requirement so proxy-authenticated Codex sessions can boot and route traffic through the sidecar.Codex provider generation (postprocess)
scripts/ci/postprocess-smoke-workflows.tsto stop emittingenv_key = "OPENAI_API_KEY"for[model_providers.openai-proxy].env_keylines from existingopenai-proxyblocks during postprocessing.Lock-file outputs updated
env_keyentries from Codex lock workflows whereopenai-proxyis injected:.github/workflows/smoke-codex.lock.yml.github/workflows/secret-digger-codex.lock.ymlRegression coverage for postprocess rules
scripts/ci/postprocess-smoke-workflows.test.tsto assert:openai-proxyconfig omitsenv_keyenv_keylines are removed without disturbing the provider block