Skip to content

refactor(tests): extract makeMockExecaProcess helper in log-streamer.test.ts #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
May 21, 2026
Merged

refactor(tests): extract makeMockExecaProcess helper in log-streamer.test.ts #3482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12d46d3
Initial plan
Copilot May 20, 2026
9240425
refactor: extract makeMockExecaProcess helper in log-streamer.test.ts
Copilot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 12 additions & 33 deletions src/logs/log-streamer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ jest.mock('../logger', () => require('../test-helpers/mock-logger.test-utils').l
const mockedExeca = execa as jest.MockedFunction<typeof execa>;
const mockedFs = fs as jest.Mocked<typeof fs>;

function makeMockExecaProcess(): { stdout: Readable; kill: jest.Mock } {
const stdout = new Readable({
read() {
this.push(null);
},
});
return { stdout, kill: jest.fn() };
}

describe('log-streamer', () => {
let stdoutWriteSpy: jest.SpyInstance;

Expand Down Expand Up @@ -83,17 +92,7 @@ describe('log-streamer', () => {
};
const formatter = new LogFormatter({ format: 'raw' });

const mockStdout = new Readable({
read() {
this.push(null);
},
});

const mockProcess = {
stdout: mockStdout,
kill: jest.fn(),
};

const mockProcess = makeMockExecaProcess();
mockedExeca.mockReturnValue(mockProcess as never);

await streamLogs({
Expand All @@ -117,17 +116,7 @@ describe('log-streamer', () => {
};
const formatter = new LogFormatter({ format: 'raw' });

const mockStdout = new Readable({
read() {
this.push(null);
},
});

const mockProcess = {
stdout: mockStdout,
kill: jest.fn(),
};

const mockProcess = makeMockExecaProcess();
mockedExeca.mockReturnValue(mockProcess as never);

// Simulate SIGTERM by resolving with signal
Expand Down Expand Up @@ -219,17 +208,7 @@ describe('log-streamer', () => {

mockedFs.existsSync.mockReturnValue(true);

const mockStdout = new Readable({
read() {
this.push(null);
},
});

const mockProcess = {
stdout: mockStdout,
kill: jest.fn(),
};

const mockProcess = makeMockExecaProcess();
mockedExeca.mockReturnValue(mockProcess as never);

await streamLogs({
Expand Down
Loading