Refactor workdir setup tests and guard fixture cleanup by Copilot · Pull Request #5303 · github/gh-aw-firewall

Copilot · 2026-06-19T22:28:09Z

Read and understand /home/runner/work/gh-aw-firewall/gh-aw-firewall/src/workdir-setup.test.ts
Extract shared setupWorkdirFixture() helper to remove duplicated setup across the test suites
Guard fixture cleanup so afterEach only removes directories when tempDir was created
Validate the affected area with lint, build, and npm test -- src/workdir-setup.test.ts

Removes ~45 duplicated lines across three describe blocks by introducing setupWorkdirFixture(). Suites opt out of chroot-home cleanup via the cleanupChrootHome option.

github-actions · 2026-06-19T23:20:35Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	97.62%	97.66%	📈 +0.04%
Statements	97.56%	97.60%	📈 +0.04%
Functions	98.85%	98.85%	➡️ +0.00%
Branches	93.24%	93.27%	📈 +0.03%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	92.7% → 94.5% (+1.82%)	92.7% → 94.5% (+1.82%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

Pull request overview

This PR refactors src/workdir-setup.test.ts to reduce duplicated boilerplate by extracting a shared setupWorkdirFixture() helper that centralizes temp dir creation, config building, and Jest hook setup/cleanup.

Changes:

Added setupWorkdirFixture() to own tempDir, buildConfig(), and shared beforeEach/afterEach.
Updated the three test suites to use the fixture (and fixture.tempDir) instead of repeating setup code.
Made chroot-home cleanup optional for the log-directories sub-function suite.

Show a summary per file

File	Description
src/workdir-setup.test.ts	Refactors workdir setup tests to use a shared fixture helper and reduce duplicated setup/cleanup code.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

  afterEach(() => {
    fs.rmSync(tempDir, { recursive: true, force: true });
-    fs.rmSync(`${tempDir}-chroot-home`, { recursive: true, force: true });
+    if (cleanupChrootHome) {
+      fs.rmSync(`${tempDir}-chroot-home`, { recursive: true, force: true });
+    }


lpcox · 2026-06-19T23:47:52Z

@copilot address the review feedback and fix the pr title and summary

lpcox · 2026-06-20T02:02:22Z

@copilot address the review feedback and fix the pr title and summary

github-actions · 2026-06-20T02:14:41Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

Copilot · 2026-06-20T02:15:17Z

@copilot address the review feedback and fix the pr title and summary

Addressed in 157fe2f. I added the tempDir guard in the shared fixture cleanup and updated the PR title/summary.

github-actions · 2026-06-20T02:22:03Z

❌ Smoke Claude failed

github-actions · 2026-06-20T02:22:05Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-20T02:22:07Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-06-20T02:22:08Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-20T02:22:08Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-06-20T02:22:08Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-06-20T02:22:08Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-20T02:22:08Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-20T02:22:08Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-20T02:22:08Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-20T02:22:09Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-20T02:22:11Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-20T02:22:11Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-06-20T02:22:14Z

✅ Contribution Check completed successfully!

github-actions · 2026-06-20T02:25:29Z

Smoke Test: Copilot BYOK ✅ PASS

Test Results:

✅ GitHub MCP connectivity (list_pull_requests: 2 merged PRs retrieved)
✅ GitHub.com HTTP connectivity (HTTP 200)
✅ File write/read operations
✅ BYOK inference path (agent → api-proxy → api.githubcopilot.com)

Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY via api-proxy sidecar)
Status: All systems operational

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-20T02:26:05Z

Smoke Test COPILOT BYOK (Direct)

MCP PR retrieval ✅
GitHub.com connectivity ✅
File I/O ✅
Direct BYOK inference ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

cc @lpcox

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-06-20T02:26:12Z

🔬 Smoke Test Results — PASS

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	✅

PR: Refactor workdir setup tests and guard fixture cleanup
Author: @Copilot | Assignees: @lpcox @Copilot

Overall: PASS ✅

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-20T02:26:13Z

Smoke Test Results — PAT Auth

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ 200
File write/read	⚠️ (template vars unexpanded)

Overall: PASS (2/2 runnable tests passed; file test skipped — ${{ }} not substituted)

Auth mode: PAT (COPILOT_GITHUB_TOKEN)
PR: "Refactor workdir setup tests and guard fixture cleanup" by @Copilot · assignees: @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-20T02:26:14Z

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Details
1. Module Loading	✅ Pass	`otel.js` loads cleanly; exports: `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled` + internal helpers
2. Test Suite	✅ Pass	59/59 tests passed across `otel.test.js` and `otel-fanout.test.js`
3. Env Var Forwarding	✅ Pass	`src/services/api-proxy-service-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, and `OTEL_SERVICE_NAME` to the api-proxy container
4. Token Tracker Integration	✅ Pass	`onUsage` callback exists at line 283/324 in `token-tracker-http.js`; `onSpanEnd` hook also present for span completion
5. OTEL Diagnostics	✅ Pass	Graceful degradation confirmed: `FileSpanExporter` fallback to `/var/log/api-proxy/otel.jsonl` when no OTLP endpoint configured

All 5 scenarios pass. OTEL tracing integration is working correctly.

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-20T02:26:35Z

Chroot Smoke Test Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.16.0	v22.22.3	❌
Go	go1.22.12	go1.22.12	✅

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot.

Tested by Smoke Chroot

github-actions · 2026-06-20T02:27:33Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5303 · 37.3 AIC · ⊞ 7.7K · ◷

github-actions · 2026-06-20T02:27:59Z

Smoke Test: Services Connectivity

Check	Result
Redis PING	❌ no response
PostgreSQL pg_isready	❌ no response
PostgreSQL SELECT 1	❌ failed

host.docker.internal resolves to 172.17.0.1 but services are not reachable.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-20T02:28:15Z

Gemini Smoke Test Results

PR [WIP] Refactor entrypoint.sh by extracting initialization phases into functions #5285: [WIP] Refactor entrypoint.sh by extracting initialization phases into functions
PR chore: upgrade gh-aw to v0.80.6 and recompile workflows #5294: chore: upgrade gh-aw to v0.80.6 and recompile workflows
GitHub MCP Testing: ✅
GitHub.com Connectivity: ✅
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall Status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-06-20T02:28:33Z

@lpcox @Copilot
PRs: Refactor extract functions in token-parsers file; Refactor to extract rule-setup phases into named bash functions
GitHub MCP: ✅
GitHub.com: ✅
File IO: ✅
BYOK path: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-20T02:29:20Z

[WIP] Refactor entrypoint.sh by extracting initialization phases into functions
[WIP] Refactor to extract rule-setup phases into named bash functions
✅ GitHub PR query
✅ GitHub discussion query/comment
✅ Playwright github.com title
✅ File write/read
✅ npm ci && npm run build
Overall: PASS

🔮 The oracle has spoken through Smoke Codex

Initial plan

47e14d4

Copilot AI assigned Copilot and lpcox Jun 19, 2026

Copilot started work on behalf of lpcox June 19, 2026 22:28 View session

refactor(tests): extract shared fixture in workdir-setup.test.ts

602c48e

Removes ~45 duplicated lines across three describe blocks by introducing setupWorkdirFixture(). Suites opt out of chroot-home cleanup via the cleanupChrootHome option.

Copilot AI requested a review from lpcox June 19, 2026 22:38

lpcox marked this pull request as ready for review June 19, 2026 23:19

Copilot AI review requested due to automatic review settings June 19, 2026 23:19

Copilot started reviewing on behalf of lpcox June 19, 2026 23:19 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Copilot started work on behalf of lpcox June 19, 2026 23:48 View session

Copilot started work on behalf of lpcox June 20, 2026 02:02 View session

test: guard temp dir cleanup in workdir fixture

157fe2f

Copilot finished work on behalf of lpcox June 20, 2026 02:14

Copilot started work on behalf of lpcox June 20, 2026 02:14 View session

lpcox changed the title ~~[WIP] Refactor workdir setup tests to reduce duplicate code~~ Refactor workdir setup tests and guard fixture cleanup Jun 20, 2026

lpcox added the ready-for-aw label Jun 20, 2026

lpcox temporarily deployed to aoai-model June 20, 2026 02:22 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok label Jun 20, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 20, 2026

github-actions Bot added the smoke-copilot-pat label Jun 20, 2026

github-actions Bot added the smoke-copilot label Jun 20, 2026

github-actions Bot added the build-test label Jun 20, 2026

lpcox temporarily deployed to aoai-model June 20, 2026 02:28 — with GitHub Actions Inactive

github-actions Bot added the smoke-gemini label Jun 20, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 20, 2026

lpcox temporarily deployed to aoai-model June 20, 2026 02:28 — with GitHub Actions Inactive

github-actions Bot added the smoke-codex label Jun 20, 2026

lpcox merged commit 8ee1833 into main Jun 20, 2026
87 of 90 checks passed

lpcox deleted the copilot/fix-duplicate-code-workdir-setup-tests branch June 20, 2026 15:35

Conversation

Copilot AI commented Jun 19, 2026 • edited by lpcox Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Coverage Check Passed

Overall Coverage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

lpcox commented Jun 19, 2026

Uh oh!

lpcox commented Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026

Uh oh!

Copilot AI commented Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 20, 2026

Smoke Test: Copilot BYOK ✅ PASS

Uh oh!

github-actions Bot commented Jun 20, 2026

Uh oh!

github-actions Bot commented Jun 20, 2026

🔬 Smoke Test Results — PASS

Uh oh!

github-actions Bot commented Jun 20, 2026

Smoke Test Results — PAT Auth

Uh oh!

github-actions Bot commented Jun 20, 2026

Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jun 20, 2026

Chroot Smoke Test Results

Uh oh!

Copilot AI commented Jun 19, 2026 •

edited by lpcox

Loading

github-actions Bot commented Jun 19, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading

github-actions Bot commented Jun 20, 2026 •

edited

Loading