fix: propagate config fields to all layers by github-actions[bot] · Pull Request #5387 · github/gh-aw-firewall

github-actions · 2026-06-22T11:19:44Z

Config Consistency Fixes

Automated audit of PRs merged in the last 7 days (up to PR #5357).

From PR #5279 + PR #5283 — duplicate `apiProxy.maxCacheMisses` in spec

PRs #5279 and #5283 both added apiProxy.maxCacheMisses to the Section 5 CLI mapping table within 20 seconds of each other, creating a duplicate entry.

Field	Fix Applied
`apiProxy.maxCacheMisses`	Removed duplicate entry from Section 5 CLI mapping table in `docs/awf-config-spec.md`

Audit Summary

All other config layers for maxCacheMisses were already correctly propagated:

Layer	Status
`src/awf-config-schema.json`	✅ Present
`docs/awf-config.schema.json`	✅ Present (identical to src)
`docs/awf-config-spec.md` § 5 CLI mapping	✅ Fixed (was duplicated)
`src/types/rate-limit-options.ts`	✅ Present
`src/config-file.ts`	✅ Present
`src/services/api-proxy-service-config.ts` (`AWF_MAX_CACHE_MISSES`)	✅ Present

Verification

Schema files remain identical (diff src/awf-config-schema.json docs/awf-config.schema.json)
No duplicate entries in spec CLI mapping table

Generated by Config Consistency Auditor · 62 AIC · ⊞ 6.6K · ◷

PRs #5279 and #5283 both added `apiProxy.maxCacheMisses` to Section 5 of the spec within 20 seconds of each other, creating a duplicate entry in the CLI mapping table. Removes the redundant second entry (after maxPermissionDenied), keeping the correct placement between maxModelMultiplierCap and maxPermissionDenied that PR #5283 added. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Removes a duplicated CLI-mapping entry for apiProxy.maxCacheMisses in the AWF config specification to keep the spec’s normative CLI mapping table consistent and non-ambiguous.

Changes:

Delete the duplicate apiProxy.maxCacheMisses → --max-cache-misses <number> row in §5 “CLI Mapping”.

Show a summary per file

File	Description
docs/awf-config-spec.md	Removes a duplicate CLI-mapping row for `apiProxy.maxCacheMisses` to avoid conflicting/duplicated spec guidance.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0

github-actions · 2026-06-22T14:46:09Z

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit 49254bf

github-actions · 2026-06-22T14:46:20Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-22T14:46:21Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-22T14:46:22Z

✅ Smoke Claude passed

github-actions · 2026-06-22T14:46:22Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke test completed with partial failure (GitHub MCP and Connectivity).

github-actions · 2026-06-22T14:46:23Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-22T14:46:23Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-22T14:46:25Z

❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

github-actions · 2026-06-22T14:46:27Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-06-22T14:46:28Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-22T14:46:32Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-22T14:46:35Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-22T14:47:00Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-22T14:49:42Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
gh CLI	✅ PASS
File access	✅ PASS

Overall result: PASS

Generated by Smoke Claude for issue #5387 · 36.8 AIC · ⊞ 3.1K · ◷

github-actions · 2026-06-22T14:49:43Z

🔬 Smoke Test Results — PASS

Test	Result
GitHub MCP (list PRs)	✅ PR #5357 "Split docker-manager cleanup tests by concern"
GitHub.com connectivity	✅ HTTP 200
File write/read	✅ `smoke-test-copilot-27961292624.txt` verified

Overall: PASS

Author: @github-actions[bot] · No assignees

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-22T14:49:46Z

Smoke Test: Copilot BYOK (Direct Mode) ✅ PASS

Running in direct BYOK mode via api-proxy → api.githubcopilot.com

✅ GitHub MCP connectivity (merged PRs loaded)
✅ GitHub.com HTTP 200
✅ File I/O working
✅ BYOK inference path active

Mention: @lpcox @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-22T14:49:59Z

Smoke test results
Current PR: fix: propagate config fields to all layers
Reviewed PRs: Split docker-manager cleanup tests by concern
Reviewed PRs: Split api-proxy token parser tests by JSON, SSE, and normalization concerns
GitHub title check: ✅
File write/read: ✅
Build: ✅
Overall status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-06-22T14:50:31Z

Smoke Test: Copilot PAT Auth — FAIL ⚠️

Test	Result
GitHub MCP connectivity	✅ Connected (fetched PR data)
GitHub.com HTTP	❌ Pre-step data unavailable (template vars not substituted)
File write/read	❌ Pre-step data unavailable (file path not resolved)

Overall: FAIL — Pre-step outputs (smoke-data) were not substituted into the workflow prompt.

Auth mode: PAT (COPILOT_GITHUB_TOKEN)
PR author: @lpcox | Assignees: @lpcox, @Copilot

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-22T14:51:19Z

Chroot Smoke Test Results

Runtime	Host Version	Chroot Version	Match?
Python	`Python 3.12.13`	`Python 3.12.3`	❌
Node.js	`v24.16.0`	`v22.22.3`	❌
Go	`go1.22.12`	`go1.22.12`	✅

Overall: ❌ Not all versions match.

Go matches, but Python and Node.js versions differ between host and chroot. The chroot environment is using older versions (Python 3.12.3, Node.js v22) compared to the host (Python 3.12.13, Node.js v24).

Tested by Smoke Chroot

github-actions · 2026-06-22T14:51:27Z

cc @lpcox

GitHub MCP connectivity: ✅
GitHub.com connectivity: ✅
File I/O test: ✅
Direct BYOK inference: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-06-22T14:51:56Z

Gemini Smoke Test Results

GitHub MCP: ❌ (mcpscripts missing)
GitHub Connectivity: ❌ (Status 400/000)
File Writing: ✅
Bash Tool: ✅

Overall Status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

github-actions · 2026-06-22T14:51:59Z

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Detail
Module Loading	✅	`otel.js` loads, `isEnabled()=true`, exports 7 public functions + test helpers
Test Suite	✅	39/39 tests passed (`otel.test.js`)
Env Var Forwarding	✅	`src/services/api-proxy-service-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME`
Token Tracker Integration	✅	`onUsage` + `onSpanEnd` callbacks present in `finalizeHttpTracking()`; `proxy-request.js` calls `startRequestSpan`/`endSpan`/`endSpanError`
OTEL Diagnostics	✅	No OTLP endpoint configured; spans fall back to `FileSpanExporter` → `/var/log/api-proxy/otel.jsonl` (graceful degradation working)

All scenarios pass. OTEL integration is functional.

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-22T14:52:12Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5387 · 42.7 AIC · ⊞ 7.7K · ◷

github-actions · 2026-06-22T14:53:48Z

Smoke Test: Services Connectivity

❌ Redis (host.docker.internal:6379): no response / timeout
❌ PostgreSQL pg_isready (host.docker.internal:5432): no response
❌ PostgreSQL SELECT 1: timeout

Overall: FAIL — service containers unreachable from runner host.

🔌 Service connectivity validated by Smoke Services

github-actions Bot added automation config-consistency labels Jun 22, 2026

lpcox marked this pull request as ready for review June 22, 2026 13:35

Copilot AI review requested due to automatic review settings June 22, 2026 13:35

Copilot started reviewing on behalf of lpcox June 22, 2026 13:35 View session

Copilot AI reviewed Jun 22, 2026

View reviewed changes

lpcox added the ready-for-aw label Jun 22, 2026

lpcox had a problem deploying to aoai-model June 22, 2026 14:46 — with GitHub Actions Failure

lpcox temporarily deployed to aoai-model June 22, 2026 14:49 — with GitHub Actions Inactive

github-actions Bot added the smoke-claude label Jun 22, 2026

github-actions Bot added the smoke-copilot label Jun 22, 2026

github-actions Bot added the smoke-copilot-byok label Jun 22, 2026

lpcox temporarily deployed to aoai-model June 22, 2026 14:49 — with GitHub Actions Inactive

github-actions Bot added the smoke-codex label Jun 22, 2026

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 22, 2026

github-actions Bot added the build-test label Jun 22, 2026

lpcox merged commit 0d122df into main Jun 22, 2026
79 of 82 checks passed

lpcox deleted the config-audit/remove-duplicate-maxcachemisses-spec-entry-9981858b46ae3683 branch June 22, 2026 15:11

github-actions Bot mentioned this pull request Jun 23, 2026

[aw] No-Op Runs #5368

Open

Uh oh!

Conversation

github-actions Bot commented Jun 22, 2026

Config Consistency Fixes

From PR #5279 + PR #5283 — duplicate apiProxy.maxCacheMisses in spec

Audit Summary

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions Bot commented Jun 22, 2026

Documentation Preview

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jun 22, 2026

🔬 Smoke Test Results — PASS

Uh oh!

github-actions Bot commented Jun 22, 2026

Smoke Test: Copilot BYOK (Direct Mode) ✅ PASS

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Smoke Test: Copilot PAT Auth — FAIL ⚠️

Uh oh!

github-actions Bot commented Jun 22, 2026

Chroot Smoke Test Results

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Gemini Smoke Test Results

Uh oh!

github-actions Bot commented Jun 22, 2026

Smoke Test: API Proxy OpenTelemetry Tracing

Uh oh!

github-actions Bot commented Jun 22, 2026

🏗️ Build Test Suite Results

Uh oh!

From PR #5279 + PR #5283 — duplicate `apiProxy.maxCacheMisses` in spec

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading