Skip to content

fix(docs-site): resolve high-severity js-yaml npm audit finding#6450

Merged
lpcox merged 1 commit into
mainfrom
fix-docs-site-npm-audit
Jul 20, 2026
Merged

fix(docs-site): resolve high-severity js-yaml npm audit finding#6450
lpcox merged 1 commit into
mainfrom
fix-docs-site-npm-audit

Conversation

@lpcox

@lpcox lpcox commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

What

Clears the high-severity `js-yaml` advisory that is failing the `dependency-audit` workflow's `--audit-level=high` gate for the docs-site package.

Applied via `npm audit fix` (non-breaking, lockfile-only):

Package Change Advisory
`js-yaml` 4.2.0 → 4.3.0 high — quadratic CPU via YAML merge-key chains (GHSA-52cp-r559-cp3m)
`dompurify` → 3.4.12 moderate — `ALLOWED_ATTR` pollution (GHSA-cmwh-pvxp-8882)
`astro` 6.4.6 → 6.4.8 patch

Only `docs-site/package-lock.json` changes — existing `package.json` version ranges already permit these.

Why

The `Audit Docs Site Package` job in `dependency-audit.yml` fails on any high/critical finding. This unblocks that gate (e.g. on #6445 and any other PR).

Verification

  • `npm ci` succeeds with the updated lockfile
  • `npm audit --audit-level=high` now exits 0 (was exit 1)
  • Resolved URLs / integrity hashes kept on the public npm registry (registry.npmjs.org, sha512)

Out of scope

  • Remaining `astro`-ecosystem moderate advisories require a breaking major bump — left for a separate change since they don't trip the high-level gate.
  • A pre-existing `astro check` build failure (`LegacyContentConfigError`, incomplete astro v6 migration) exists on `main` independent of this change.

Bump transitive deps via 'npm audit fix' to clear the high-severity
js-yaml advisory (GHSA-52cp-r559-cp3m) that was failing the
dependency-audit workflow's --audit-level=high gate:

- js-yaml 4.2.0 -> 4.3.0 (high: quadratic CPU via YAML merge keys)
- dompurify -> 3.4.12 (moderate: ALLOWED_ATTR pollution)
- astro 6.4.6 -> 6.4.8 (patch)

Only the lockfile changes; package.json ranges already permit these.
Remaining astro-related moderate advisories require a breaking major
bump and are out of scope for this audit-gate fix.
Copilot AI review requested due to automatic review settings July 20, 2026 22:32
@github-actions

Copy link
Copy Markdown
Contributor

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit e01bc09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • docs-site/package-lock.json: Generated file

@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.76% 98.79% 📈 +0.03%
Statements 98.70% 98.73% 📈 +0.03%
Functions 99.28% 99.28% ➡️ +0.00%
Branches 95.01% 95.01% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.2% → 100.0% (+3.78%) 96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@lpcox
lpcox merged commit 37ae38e into main Jul 20, 2026
23 of 25 checks passed
@lpcox
lpcox deleted the fix-docs-site-npm-audit branch July 20, 2026 22:49
@github-actions github-actions Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants