Skip to content

Commit d5a93a8

Browse files
authored
Redact URL values in GitHub API debug logs
1 parent 2db3f8d commit d5a93a8

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

internal/envutil/github.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"strings"
88

99
"github.com/github/gh-aw-mcpg/internal/logger"
10+
"github.com/github/gh-aw-mcpg/internal/logger/sanitize"
1011
)
1112

1213
var logGitHub = logger.New("envutil:github")
@@ -66,12 +67,12 @@ func DeriveGitHubAPIURL(defaultURL string) string {
6667
if serverURL := strings.TrimSpace(os.Getenv("GITHUB_SERVER_URL")); serverURL != "" {
6768
derived := deriveAPIFromServerURL(serverURL)
6869
if derived != "" {
69-
logGitHub.Printf("GitHub API URL derived from GITHUB_SERVER_URL=%s: %s", serverURL, derived)
70+
logGitHub.Printf("GitHub API URL derived from GITHUB_SERVER_URL=%s: %s", sanitize.RedactURL(serverURL), sanitize.RedactURL(derived))
7071
return derived
7172
}
7273
}
7374
result := strings.TrimRight(strings.TrimSpace(defaultURL), "/")
74-
logGitHub.Printf("GitHub API URL falling back to provided default: %s", result)
75+
logGitHub.Printf("GitHub API URL falling back to provided default: %s", sanitize.RedactURL(result))
7576
return result
7677
}
7778

@@ -80,15 +81,15 @@ func DeriveGitHubAPIURL(defaultURL string) string {
8081
// GitHub.com: https://github.com → https://api.github.com
8182
// GHES (all others): https://github.example.com → https://github.example.com/api/v3
8283
func deriveAPIFromServerURL(serverURL string) string {
83-
logGitHub.Printf("Deriving API URL from server URL: %s", serverURL)
84+
logGitHub.Printf("Deriving API URL from server URL: %s", sanitize.RedactURL(serverURL))
8485

8586
parsed, err := url.Parse(strings.TrimRight(serverURL, "/"))
8687
if err != nil || parsed.Host == "" {
87-
logGitHub.Printf("Failed to parse server URL or empty host: serverURL=%s, err=%v", serverURL, err)
88+
logGitHub.Printf("Failed to parse server URL or empty host: serverURL=%s, err=%v", sanitize.RedactURL(serverURL), err)
8889
return ""
8990
}
9091
if parsed.Scheme != "http" && parsed.Scheme != "https" {
91-
logGitHub.Printf("Unsupported scheme in server URL: scheme=%s, serverURL=%s", parsed.Scheme, serverURL)
92+
logGitHub.Printf("Unsupported scheme in server URL: scheme=%s, serverURL=%s", parsed.Scheme, sanitize.RedactURL(serverURL))
9293
return ""
9394
}
9495

0 commit comments

Comments
 (0)