Skip to content

[smoke-safeoutputs] Smoke Safe-Outputs PRs: 26165137322 #6091

@github-actions

Description

@github-actions

Safe-Outputs Pull Requests Enforcement Test Results

Run: https://github.com/github/gh-aw-mcpg/actions/runs/26165137322
Trigger: schedule
Configuration: create-pull-request (max:1, prefix, draft:true), close-pull-request (required-labels, required-prefix, max:1), update-pull-request (title:true, body:false, max:1), push-to-pr-branch (target:triggering, prefix), mark-ready (required-labels:[smoke-test], max:1), add-reviewer (reviewers:[copilot], max:1)

Note: All safeoutputs tool calls return {"result":"success"} at the MCP layer. Enforcement (rejection, max limits, label/prefix checks) appears to be deferred to the workflow orchestration layer when actions are committed/applied. Phase 3 tests are SKIPPED (schedule trigger — no triggering PR).

Phase 1: create-pull-request

Test Operation Expected Actual Status
1.1 Create draft PR (valid prefix) ✅ Processed {"result":"success","patch":{...}} — PR queued, not yet visible in GitHub
1.2 Create PR without prefix ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)
1.3 Create 2nd PR (max exceeded) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)

Phase 2: update-pull-request (title:true, body:false)

Test Operation Expected Actual Status
2.1 Update title (allowed) ✅ Processed {"result":"success"} — PR #6082 title update accepted
2.2 Update body (body: false) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)
2.3 2nd update (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)

Phase 3: push-to-pull-request-branch (target:triggering)

Test Operation Expected Actual Status
3.1 Push to triggering PR (matching prefix) ✅ Processed SKIPPED — schedule trigger, no triggering PR ✅ SKIPPED
3.2 Push to non-triggering PR ❌ Rejected SKIPPED — schedule trigger, no triggering PR ✅ SKIPPED
3.3 Push to PR without matching prefix ❌ Rejected SKIPPED — schedule trigger, no triggering PR ✅ SKIPPED

Phase 4: mark-pull-request-as-ready-for-review (required-labels:[smoke-test])

Test Operation Expected Actual Status
4.1 Mark PR with smoke-test label as ready ✅ Processed SKIPPED — no smoke-test label PR available (created PR deferred) ✅ SKIPPED
4.2 Mark PR without required label as ready ❌ Rejected {"result":"success"} on PR #6082 (no smoke-test label) — enforcement deferred
4.3 2nd mark-as-ready (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)

Phase 5: add-reviewer (reviewers:[copilot])

Test Operation Expected Actual Status
5.1 Add reviewer "copilot" (allowed) ✅ Processed {"result":"success"} on PR #6082
5.2 Add non-allowed reviewer ❌ Rejected {"result":"success"} for reviewer "lpcox" — enforcement deferred
5.3 Add 2nd reviewer (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)

Phase 6: close-pull-request (required-labels, required-prefix)

Test Operation Expected Actual Status
6.1 Close PR with required label+prefix ✅ Processed SKIPPED — no smoke-test+[smoke-safeoutputs] PR available ✅ SKIPPED
6.2 Close PR without required label ❌ Rejected {"result":"success"} on PR #6082 (no smoke-test label) — enforcement deferred
6.3 Close PR without required prefix ❌ Rejected {"result":"success"} on PR #6050 ("[test-improver]" prefix) — enforcement deferred
6.4 2nd close (max: 1 exceeded) ❌ Rejected {"result":"success"} — tool accepted (enforcement deferred)

Summary

  • Phase 1 (create-pull-request): 1/3 ✅ (enforcement deferred — negative cases not rejected at tool layer)
  • Phase 2 (update-pull-request): 1/3 ✅ (enforcement deferred — body:false and max not enforced at tool layer)
  • Phase 3 (push-to-pr-branch): 3/3 ✅ SKIPPED (schedule trigger)
  • Phase 4 (mark-ready): 1/3 ✅ (1 skipped; enforcement deferred — label check not enforced at tool layer)
  • Phase 5 (add-reviewer): 1/3 ✅ (enforcement deferred — reviewer allowlist and max not enforced at tool layer)
  • Phase 6 (close-pull-request): 1/4 ✅ (1 skipped; enforcement deferred — label/prefix checks not enforced at tool layer)
  • Overall: FAIL — safeoutputs tool layer does not enforce constraints at call time; all negative test cases returned {"result":"success"}. Enforcement is deferred to workflow orchestration layer.

🔀 Safe-outputs PRs enforcement test by Smoke Safe-Outputs PRs

  • expires on May 20, 2026, 3:25 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions