Upgrade go-sdk to v1.6.0 and consolidate session-missing detection#6017
Conversation
|
@copilot fix the failing linting ci check |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s core MCP dependency (modelcontextprotocol/go-sdk) to v1.6.0 and slightly refactors the HTTP transport session-missing detection to remove duplicated string literals, while also updating one SDK-contract annotation.
Changes:
- Bump
github.com/modelcontextprotocol/go-sdkfromv1.5.0tov1.6.0(and refresh transitive sums, incl.github.com/google/jsonschema-go). - Consolidate
"session not found"matching into a shared constant ininternal/mcp/http_transport.go. - Update the bypass-validation SDK behavior note in
internal/server/tool_registry.goto reference v1.6.0 verification.
Show a summary per file
| File | Description |
|---|---|
| internal/server/tool_registry.go | Updates the SDK-contract verification comment to v1.6.0. |
| internal/mcp/http_transport.go | Introduces sessionNotFoundMessage constant and reuses it in both session-missing detectors. |
| go.mod | Upgrades go-sdk to v1.6.0 and bumps jsonschema-go indirect dependency. |
| go.sum | Refreshes checksums for upgraded direct/transitive modules. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/4 changed files
- Comments generated: 1
| HTTPTransportSSE HTTPTransportType = "sse" | ||
| // HTTPTransportPlainJSON uses plain JSON-RPC 2.0 over HTTP POST (non-standard) | ||
| HTTPTransportPlainJSON HTTPTransportType = "plain-json" | ||
| sessionNotFoundMessage = "session not found" | ||
| ) |
|
@copilot address the review feedback |
Fixed in the latest commit. The |
Done. Updated all three stale |
This module is the core MCP dependency in
gh-aw-mcpg, and the repo was one minor version behind onmodelcontextprotocol/go-sdk. This PR updates the SDK and tightens a small MCP transport code path called out in the review by removing duplicated session-not-found string matching.Dependency refresh
github.com/modelcontextprotocol/go-sdkfromv1.5.0tov1.6.0.github.com/google/jsonschema-go).Session-not-found detection cleanup
internal/mcp/http_transport.go.isSessionNotFoundErrorisSessionNotFoundHTTPResponseSDK contract annotation update
internal/server/tool_registry.goto reflect verification against go-sdkv1.6.0.