Skip to content

[test-improver] Improve tests for config package: fix flaky network error test #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
May 20, 2026
Merged

[test-improver] Improve tests for config package: fix flaky network error test #6050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d512d8b
Fix flaky TestFetchAndFixSchema_NetworkError test
github-actions[bot] May 20, 2026
827721c
test: tighten network error assertion in schema fetch test
Copilot May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions internal/config/validation_schema_fetch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,13 @@ func TestFetchAndFixSchema_HTTPError(t *testing.T) {

// TestFetchAndFixSchema_NetworkError tests handling of network failures
func TestFetchAndFixSchema_NetworkError(t *testing.T) {
// Use an invalid URL that will cause a network error
invalidURL := "http://invalid-host-that-does-not-exist-12345.com/schema.json"
// Start a server and immediately close it so connections are refused,
// guaranteeing a network error without relying on external DNS resolution.
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
closedURL := server.URL + "/schema.json"
server.Close()

result, err := fetchAndFixSchema(invalidURL)
result, err := fetchAndFixSchema(closedURL)

assert.Error(t, err)
assert.Nil(t, result)
Expand Down
Loading