Fail smoke detection jobs on parsing errors#107
Merged
Conversation
Copilot
AI
changed the title
Make smoke threat detection failures blocking
Fail smoke detection jobs on parsing errors
May 14, 2026
Copilot created this pull request from a session on behalf of
davidslater
May 14, 2026 00:29
View session
This was referenced May 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Sets safe-outputs.threat-detection.continue-on-error: false in the three smoke workflow source files (Copilot, Claude, Codex) so that threat-detection parsing errors fail the smoke job rather than being silently ignored. The base .lock.yml files and their containerized siblings have been recompiled to match — removing continue-on-error: true on the "Parse and conclude threat detection" step and flipping GH_AW_DETECTION_CONTINUE_ON_ERROR to "false".
Changes:
- Add
threat-detection.continue-on-error: falseto the three smoke.mdsource workflows and their-container.mdsiblings. - Recompile the six
.lock.ymlfiles: drop the step-levelcontinue-on-error: trueand setGH_AW_DETECTION_CONTINUE_ON_ERROR: "false"on the detection_conclusion step. - Update frontmatter hashes in the lock files to match the new source.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-copilot.md | Add blocking threat-detection config |
| .github/workflows/smoke-copilot.lock.yml | Recompiled to fail on detection errors |
| .github/workflows/smoke-copilot-container.md | Mirror blocking config in sibling |
| .github/workflows/smoke-copilot-container.lock.yml | Recompiled containerized sibling |
| .github/workflows/smoke-claude.md | Add blocking threat-detection config |
| .github/workflows/smoke-claude.lock.yml | Recompiled to fail on detection errors |
| .github/workflows/smoke-claude-container.md | Mirror blocking config in sibling |
| .github/workflows/smoke-claude-container.lock.yml | Recompiled containerized sibling |
| .github/workflows/smoke-codex.md | Add blocking threat-detection config |
| .github/workflows/smoke-codex.lock.yml | Recompiled to fail on detection errors |
| .github/workflows/smoke-codex-container.md | Mirror blocking config in sibling |
| .github/workflows/smoke-codex-container.lock.yml | Recompiled containerized sibling |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 12/12 changed files
- Comments generated: 0
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
Smoke threat-detection jobs could report success even when detection result parsing or other detection errors occurred.
How did you fix it?
safe-outputs.threat-detection.continue-on-error: falsefor Copilot, Claude, and Codex smoke workflows..lock.ymlworkflows.Testing