Skip to content

Fix detection-only reflect endpoint#115

Merged
davidslater merged 7 commits into
mainfrom
copilot/optimize-detection-job-iteration
May 14, 2026
Merged

Fix detection-only reflect endpoint#115
davidslater merged 7 commits into
mainfrom
copilot/optimize-detection-job-iteration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

Bug Fix

What was the bug?

The detection-only workflow pointed threat-detect at a host-side /reflect URL with no listener. The detector runs inside AWF and needs to call the internal api-proxy endpoint instead.

How did you fix it?

  • Reflect routing
    • Updated THREAT_DETECTION_REFLECT_URL to the AWF api-proxy service.
    • Added an inline workflow comment documenting the container-network endpoint.
THREAT_DETECTION_REFLECT_URL: http://api-proxy:10000/reflect
  • Fixture cleanup
    • Removed the unused safe fixture directory.
    • Made patch the only/default detection-only fixture.

Copilot AI changed the title Add detection-only workflow Add detection-only workflow for faster detector iteration May 14, 2026
Copilot AI requested a review from davidslater May 14, 2026 22:10
@davidslater davidslater marked this pull request as ready for review May 14, 2026 23:20
Copilot AI review requested due to automatic review settings May 14, 2026 23:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a lightweight, manual GitHub Actions workflow to run the repository’s generated detection job against local fixture artifacts, enabling faster iteration on detector behavior without running the full activation/agent pipeline.

Changes:

  • Added a workflow_dispatch “detection-only” workflow that stubs activation/agent and runs the containerized detection job using uploaded fixture artifacts.
  • Added safe and patch fixtures under testdata/detection-only/ (prompt + agent_output.json, plus a sample aw-*.patch for the patch case).
  • Documented the new workflow and fixture mapping in README.md.
Show a summary per file
File Description
.github/workflows/detection-only.yml New manual workflow that uploads fixture data as an agent artifact and runs the copied detection job against it.
README.md Documents the purpose and mechanics of the new detection-only workflow.
testdata/detection-only/safe/aw-prompts/prompt.txt Adds “safe” prompt fixture content.
testdata/detection-only/safe/agent_output.json Adds “safe” agent output fixture.
testdata/detection-only/patch/aw-prompts/prompt.txt Adds “patch” prompt fixture content.
testdata/detection-only/patch/agent_output.json Adds “patch” agent output fixture.
testdata/detection-only/patch/aw-docs.patch Adds a sample aw-*.patch fixture to exercise patch-handling paths.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 7/7 changed files
  • Comments generated: 2

Comment thread .github/workflows/detection-only.yml Outdated
Comment thread .github/workflows/detection-only.yml Outdated
davidslater and others added 2 commits May 14, 2026 16:25
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI changed the title Add detection-only workflow for faster detector iteration Fix detection-only reflect endpoint May 14, 2026
@davidslater davidslater enabled auto-merge (squash) May 14, 2026 23:35
@davidslater davidslater disabled auto-merge May 14, 2026 23:36
@davidslater davidslater merged commit 4bc4c5e into main May 14, 2026
8 checks passed
@davidslater davidslater deleted the copilot/optimize-detection-job-iteration branch May 14, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants