Skip to content

Append Containerized to generated smoke workflow names#65

Merged
davidslater merged 2 commits into
mainfrom
copilot/update-workflow-name-containerized
May 13, 2026
Merged

Append Containerized to generated smoke workflow names#65
davidslater merged 2 commits into
mainfrom
copilot/update-workflow-name-containerized

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Bug Fix

What was the bug?

Containerized AW smoke lock workflows kept the same top-level workflow names as their source workflows, making base and containerized runs indistinguishable in Actions.

name: "Smoke Claude"

How did you fix it?

  • Generator update

    • Changed scripts/create-threat-detection-sibling-workflows.py so generated container siblings append Containerized to name and run-name.
  • Regenerated lock workflows

    • Updated the generated smoke container lock files:
      • Smoke Copilot Containerized
      • Smoke Claude Containerized
      • Smoke Codex Containerized
name: "Smoke Claude Containerized"
run-name: "Smoke Claude Containerized"

Copilot AI requested a review from davidslater May 13, 2026 19:54
@davidslater davidslater marked this pull request as ready for review May 13, 2026 20:20
Copilot AI review requested due to automatic review settings May 13, 2026 20:20
@davidslater davidslater merged commit a9199eb into main May 13, 2026
10 checks passed
@davidslater davidslater deleted the copilot/update-workflow-name-containerized branch May 13, 2026 20:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an Actions UX issue where containerized smoke workflows were indistinguishable from their base smoke workflows by updating the generated container sibling workflows to include a Containerized suffix in the top-level workflow name and run-name.

Changes:

  • Updated the container sibling workflow generator to use “… Containerized” as the sibling display name.
  • Regenerated the three smoke-*-container.lock.yml workflows with updated name and run-name.
  • Ensured containerized runs appear as distinct workflows in the GitHub Actions UI.
Show a summary per file
File Description
scripts/create-threat-detection-sibling-workflows.py Updates the generator’s per-engine sibling display name to include Containerized.
.github/workflows/smoke-copilot-container.lock.yml Regenerated containerized Copilot smoke lock workflow with updated name/run-name.
.github/workflows/smoke-claude-container.lock.yml Regenerated containerized Claude smoke lock workflow with updated name/run-name.
.github/workflows/smoke-codex-container.lock.yml Regenerated containerized Codex smoke lock workflow with updated name/run-name.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 4

Comment on lines 21 to 25
ENGINES = {
"smoke-copilot.lock.yml": ("copilot", "Smoke Copilot"),
"smoke-claude.lock.yml": ("claude", "Smoke Claude"),
"smoke-codex.lock.yml": ("codex", "Smoke Codex"),
"smoke-copilot.lock.yml": ("copilot", "Smoke Copilot Containerized"),
"smoke-claude.lock.yml": ("claude", "Smoke Claude Containerized"),
"smoke-codex.lock.yml": ("codex", "Smoke Codex Containerized"),
}
# - node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f

name: "Smoke Copilot"
name: "Smoke Copilot Containerized"
# - node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f

name: "Smoke Claude"
name: "Smoke Claude Containerized"
# - node:lts-alpine@sha256:d1b3b4da11eefd5941e7f0b9cf17783fc99d9c6fc34884a665f40a06dbdfc94f

name: "Smoke Codex"
name: "Smoke Codex Containerized"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants