Skip to content

Commit 0a6c750

Browse files
authored
Soft-skip submit_pull_request_review when no PR review context is available (#33435)
1 parent 2ede330 commit 0a6c750

3 files changed

Lines changed: 12 additions & 7 deletions

File tree

actions/setup/js/pr_review_buffer.cjs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,12 @@ function createReviewBuffer() {
235235
}
236236

237237
if (!reviewContext) {
238-
core.warning("No review context set - cannot submit review");
239-
return { success: false, error: "No review context available" };
238+
core.info("No review context set - skipping PR review submission");
239+
return {
240+
success: true,
241+
skipped: true,
242+
reason: "No review context available",
243+
};
240244
}
241245

242246
const { repo, repoParts, pullRequestNumber, pullRequest } = reviewContext;

actions/setup/js/pr_review_buffer.test.cjs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,14 @@ describe("pr_review_buffer (factory pattern)", () => {
179179
expect(mockGithub.rest.pulls.createReview).not.toHaveBeenCalled();
180180
});
181181

182-
it("should fail when no review context is set", async () => {
182+
it("should skip when no review context is set", async () => {
183183
buffer.addComment({ path: "test.js", line: 1, body: "comment" });
184184

185185
const result = await buffer.submitReview();
186186

187-
expect(result.success).toBe(false);
188-
expect(result.error).toContain("No review context available");
187+
expect(result.success).toBe(true);
188+
expect(result.skipped).toBe(true);
189+
expect(result.reason).toContain("No review context available");
189190
});
190191

191192
it("should fail when PR head SHA is missing", async () => {

actions/setup/js/submit_pr_review.test.cjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -729,8 +729,8 @@ describe("submit_pr_review (Handler Factory Architecture)", () => {
729729
expect(result.success).toBe(true);
730730
expect(localBuffer.hasReviewMetadata()).toBe(true);
731731

732-
// Review context should NOT be set because the disallowed repo was rejected
733-
// submitReview() will subsequently fail with "No review context available"
732+
// Review context should NOT be set because the disallowed repo was rejected.
733+
// submitReview() will subsequently be skipped due to missing review context.
734734
expect(localBuffer.getReviewContext()).toBeNull();
735735

736736
delete global.context;

0 commit comments

Comments
 (0)