perf: optimize compile config validation tests (#3788)

Author: github-actions[bot]

pkg/cli/compile_command.go

@@ -173,6 +173,32 @@ type CompilationStats struct {
 	FailedWorkflows []string // Names of workflows that failed compilation
 }
 
+// validateCompileConfig validates the configuration flags before compilation
+// This is extracted for faster testing without full compilation
+func validateCompileConfig(config CompileConfig) error {
+	// Validate dependabot flag usage
+	if config.Dependabot {
+		if len(config.MarkdownFiles) > 0 {
+			return fmt.Errorf("--dependabot flag cannot be used with specific workflow files")
+		}
+		if config.WorkflowDir != "" && config.WorkflowDir != ".github/workflows" {
+			return fmt.Errorf("--dependabot flag cannot be used with custom --workflows-dir")
+		}
+	}
+
+	// Validate purge flag usage
+	if config.Purge && len(config.MarkdownFiles) > 0 {
+		return fmt.Errorf("--purge flag can only be used when compiling all markdown files (no specific files specified)")
+	}
+
+	// Validate workflow directory path
+	if config.WorkflowDir != "" && filepath.IsAbs(config.WorkflowDir) {
+		return fmt.Errorf("workflows-dir must be a relative path, got: %s", config.WorkflowDir)
+	}
+
+	return nil
+}
+
 func CompileWorkflows(config CompileConfig) ([]*workflow.WorkflowData, error) {
 	markdownFiles := config.MarkdownFiles
 	verbose := config.Verbose
@@ -196,30 +222,16 @@ func CompileWorkflows(config CompileConfig) ([]*workflow.WorkflowData, error) {
 	// Track compilation statistics
 	stats := &CompilationStats{}
 
-	// Validate dependabot flag usage
-	if dependabot {
-		if len(markdownFiles) > 0 {
-			return nil, fmt.Errorf("--dependabot flag cannot be used with specific workflow files")
-		}
-		if workflowDir != "" && workflowDir != ".github/workflows" {
-			return nil, fmt.Errorf("--dependabot flag cannot be used with custom --workflows-dir")
-		}
-	}
-
-	// Validate purge flag usage
-	if purge && len(markdownFiles) > 0 {
-		return nil, fmt.Errorf("--purge flag can only be used when compiling all markdown files (no specific files specified)")
+	// Validate configuration
+	if err := validateCompileConfig(config); err != nil {
+		return nil, err
 	}
 
 	// Validate and set default for workflow directory
 	if workflowDir == "" {
 		workflowDir = ".github/workflows"
 		compileLog.Printf("Using default workflow directory: %s", workflowDir)
 	} else {
-		// Ensure the path is relative
-		if filepath.IsAbs(workflowDir) {
-			return nil, fmt.Errorf("workflows-dir must be a relative path, got: %s", workflowDir)
-		}
 		// Clean the path to avoid issues with ".." or other problematic elements
 		workflowDir = filepath.Clean(workflowDir)
 		compileLog.Printf("Using custom workflow directory: %s", workflowDir)

pkg/cli/compile_command_test.go

@@ -137,6 +137,7 @@ func TestCompileWorkflowWithValidation_InvalidFile(t *testing.T) {
 }
 
 // TestCompileWorkflows_DependabotValidation tests dependabot flag validation
+// Uses the fast validateCompileConfig function instead of full compilation
 func TestCompileWorkflows_DependabotValidation(t *testing.T) {
 	tests := []struct {
 		name        string
@@ -174,27 +175,32 @@ func TestCompileWorkflows_DependabotValidation(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			_, err := CompileWorkflows(tt.config)
+			// Use fast validation function instead of full compilation
+			err := validateCompileConfig(tt.config)
 
 			if tt.expectError {
 				if err == nil {
 					t.Error("Expected error but got nil")
 				} else if !strings.Contains(err.Error(), tt.errorMsg) {
 					t.Errorf("Expected error containing %q, got %q", tt.errorMsg, err.Error())
 				}
+			} else if err != nil {
+				t.Errorf("Expected no error but got: %v", err)
 			}
 		})
 	}
 }
 
 // TestCompileWorkflows_PurgeValidation tests purge flag validation
+// Uses the fast validateCompileConfig function instead of full compilation
 func TestCompileWorkflows_PurgeValidation(t *testing.T) {
 	config := CompileConfig{
 		Purge:         true,
 		MarkdownFiles: []string{"test.md"},
 	}
 
-	_, err := CompileWorkflows(config)
+	// Use fast validation function instead of full compilation
+	err := validateCompileConfig(config)
 
 	if err == nil {
 		t.Error("Expected error when using purge with specific files, got nil")
@@ -206,6 +212,7 @@ func TestCompileWorkflows_PurgeValidation(t *testing.T) {
 }
 
 // TestCompileWorkflows_WorkflowDirValidation tests workflow directory validation
+// Uses the fast validateCompileConfig function instead of full compilation
 func TestCompileWorkflows_WorkflowDirValidation(t *testing.T) {
 	tests := []struct {
 		name        string
@@ -237,14 +244,17 @@ func TestCompileWorkflows_WorkflowDirValidation(t *testing.T) {
 				WorkflowDir: tt.workflowDir,
 			}
 
-			_, err := CompileWorkflows(config)
+			// Use fast validation function instead of full compilation
+			err := validateCompileConfig(config)
 
 			if tt.expectError {
 				if err == nil {
 					t.Error("Expected error but got nil")
 				} else if !strings.Contains(err.Error(), tt.errorMsg) {
 					t.Errorf("Expected error containing %q, got %q", tt.errorMsg, err.Error())
 				}
+			} else if err != nil {
+				t.Errorf("Expected no error but got: %v", err)
 			}
 		})
 	}