fix: convert double quotes to single quotes in experiment comparison expressions (#31770)

Author: Copilot

.github/workflows/daily-fact.lock.yml

@@ -99,7 +99,7 @@ Mine recent activity from the repository to find interesting facts. Focus on:
 ## Guidelines
 
 - **Check memory first**: Skip any PR, issue, or release that already appears in the palace results from Step 0
-{{#if experiments.reasoning_depth == "multi_candidate"}}
+{{#if experiments.reasoning_depth == 'multi_candidate'}}
 - **Multi-candidate deliberation**: Before writing, identify exactly **3 distinct candidate facts** (one PR, one issue or release, one contributor or pattern). For each candidate write one sentence on why it is novel today. Then score each candidate 1–5 on: (a) novelty vs palace memory, (b) intrinsic poetic potential. Select the highest-scoring candidate and write the verse for that one only.
 {{else}}
 - **Favor recent updates** but include variety - pick something interesting, not just the most recent

.github/workflows/daily-fact.md

@@ -6,6 +6,7 @@ import (
 	"os"
 	"path/filepath"
 
+	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/logger"
 	"github.com/github/gh-aw/pkg/parser"
 )
@@ -141,6 +142,15 @@ func (c *Compiler) parseFrontmatterSection(markdownPath string) (*frontmatterPar
 		return nil, fmt.Errorf("template condition validation failed: %w", err)
 	}
 
+	// Warn when experiment comparison expressions use double-quoted string literals.
+	// GitHub Actions expression syntax only supports single-quoted string literals, so
+	// the compiler converts double quotes to single quotes automatically — but authors
+	// should fix the source to use single quotes to keep it consistent with the output.
+	for _, w := range detectDoubleQuotedExperimentComparisons(result.Markdown) {
+		fmt.Fprintln(os.Stderr, console.FormatWarningMessage(w))
+		c.IncrementWarningCount()
+	}
+
 	log.Printf("Frontmatter: %d chars, Markdown: %d chars", len(result.Frontmatter), len(result.Markdown))
 
 	return &frontmatterParseResult{

pkg/workflow/compiler_orchestrator_frontmatter.go

@@ -150,7 +150,7 @@ permissions:
 strict: false
 ---
 
-{{#if experiments.prompt_style == "detailed"}}
+{{#if experiments.prompt_style == 'detailed'}}
 detailed prompt
 {{else}}
 concise prompt