Skip to content

Commit 551a025

Browse files
CopilotMossaka
andauthored
Fix test-proxy.md to use automatic comment creation instead of manual GitHub tools (#190)
* Update test-proxy.md to use comments instead of creating issues Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * changed the instruction to comment on PR instead of raising a new issue Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com> * Remove create_comment tool and add inline PR number as requested in review comments Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> --------- Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> Co-authored-by: Jiaxiao Zhou <duibao55328@gmail.com>
1 parent 3aa44ad commit 551a025

2 files changed

Lines changed: 115 additions & 14 deletions

File tree

.github/workflows/test-proxy.lock.yml

Lines changed: 106 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/test-proxy.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ on:
44
branches: [ "main" ]
55
workflow_dispatch:
66

7-
permissions:
8-
issues: write # needed to write the output report to an issue
7+
output:
8+
issue_comment: {}
99

1010
tools:
1111
fetch:
@@ -21,8 +21,6 @@ tools:
2121

2222
github:
2323
allowed:
24-
- "create_issue"
25-
- "create_comment"
2624
- "get_issue"
2725

2826
engine: claude
@@ -44,10 +42,14 @@ Test the MCP network permissions feature to validate that domain restrictions ar
4442
- Verify that all blocked requests fail at the network level (proxy enforcement)
4543
- Confirm that only example.com is accessible through the Squid proxy
4644

47-
Create a GitHub issue with the test results, documenting:
45+
## Reporting Instructions
46+
47+
If there are any failures, security issues, or unexpected behaviors:
48+
49+
- Write a detailed report to ${{ env.GITHUB_AW_OUTPUT }} documenting:
4850
- Which domains were successfully accessed vs blocked
4951
- Error messages received for blocked domains
50-
- Confirmation that network isolation is working correctly
5152
- Any security observations or recommendations
53+
- Specific failure details that need attention
5254

53-
The test should demonstrate that MCP containers are properly isolated and can only access explicitly allowed domains through the network proxy.
55+
The test results will be automatically posted as a comment on PR #${{ github.event.pull_request.number }}.

0 commit comments

Comments
 (0)