Enable mcp-gateway in smoke-copilot and remove feature flag

- Move IMPLEMENTATION_SUMMARY.md to specs/mcp-gateway.md
- Remove feature flag requirement from gateway.go
- Enable mcp-gateway in smoke-copilot.md workflow
- Add MCP gateway test requirement to smoke-copilot
- Integrate gateway step generation in mcp_servers.go
- Update tests to reflect feature flag removal

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

.github/workflows/smoke-copilot.lock.yml

@@ -21,6 +21,9 @@ network:
     - github
 sandbox:
   agent: awf  # Firewall enabled
+  mcp:
+    container: ghcr.io/githubnext/mcp-gateway
+    port: 8080
 tools:
   cache-memory: true
   edit:
@@ -54,7 +57,8 @@ strict: true
 3. **Bash Tool Testing**: Execute bash commands to verify file creation was successful (use `cat` to read the file back)
 4. **GitHub MCP Default Toolset Testing**: Verify that the `get_me` tool is NOT available with default toolsets. Try to use it and confirm it fails with a tool not found error.
 5. **Cache Memory Testing**: Write a test file to `/tmp/gh-aw/cache-memory/smoke-test-${{ github.run_id }}.txt` with content "Cache memory test for run ${{ github.run_id }}" and verify it was created successfully
-6. **Available Tools Display**: List all available tools that you have access to in this workflow execution.
+6. **MCP Gateway Testing**: Verify that the MCP gateway is running by checking if the container is active and the health endpoint is accessible
+7. **Available Tools Display**: List all available tools that you have access to in this workflow execution.
 
 ## Output
 

.github/workflows/smoke-copilot.md

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/githubnext/gh-aw/pkg/constants"
 	"github.com/githubnext/gh-aw/pkg/logger"
 )
 
@@ -44,8 +43,8 @@ func isMCPGatewayEnabled(workflowData *WorkflowData) bool {
 		return false
 	}
 
-	// Then check if the feature flag is enabled
-	return isFeatureEnabled(constants.MCPGatewayFeatureFlag, workflowData)
+	// MCP gateway is enabled by default when sandbox.mcp is configured
+	return true
 }
 
 // getMCPGatewayConfig extracts the MCPGatewayConfig from sandbox configuration

pkg/workflow/gateway.go

@@ -129,27 +129,24 @@ func TestIsMCPGatewayEnabled(t *testing.T) {
 			expected: false,
 		},
 		{
-			name: "sandbox.mcp without feature flag",
+			name: "sandbox.mcp configured",
 			data: &WorkflowData{
 				SandboxConfig: &SandboxConfig{
 					MCP: &MCPGatewayConfig{
 						Container: "test",
 					},
 				},
 			},
-			expected: false,
+			expected: true,
 		},
 		{
-			name: "sandbox.mcp with feature flag",
+			name: "sandbox.mcp configured",
 			data: &WorkflowData{
 				SandboxConfig: &SandboxConfig{
 					MCP: &MCPGatewayConfig{
 						Container: "test",
 					},
 				},
-				Features: map[string]bool{
-					"mcp-gateway": true,
-				},
 			},
 			expected: true,
 		},

pkg/workflow/gateway_test.go

@@ -542,6 +542,15 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any,
 		yaml.WriteString("          \n")
 	}
 
+	// Generate MCP gateway steps if configured
+	// Note: Currently passing nil for mcpServersConfig as the gateway is configured via Docker
+	gatewaySteps := generateMCPGatewaySteps(workflowData, nil)
+	for _, step := range gatewaySteps {
+		for _, line := range step {
+			yaml.WriteString(line + "\n")
+		}
+	}
+
 	// Use the engine's RenderMCPConfig method
 	yaml.WriteString("      - name: Setup MCPs\n")