Consolidate duplicate string extraction functions in pkg/workflow (#3626)

Author: Copilot

pkg/workflow/compiler.go

@@ -915,7 +915,7 @@ func (c *Compiler) ParseWorkflowFile(markdownPath string) (*WorkflowData, error)
 	}
 
 	// Check if frontmatter specifies a custom name and use it instead
-	frontmatterName := extractStringValue(result.Frontmatter, "name")
+	frontmatterName := extractStringFromMap(result.Frontmatter, "name", nil)
 	if frontmatterName != "" {
 		workflowName = frontmatterName
 	}
@@ -954,7 +954,7 @@ func (c *Compiler) ParseWorkflowFile(markdownPath string) (*WorkflowData, error)
 		ToolsStartupTimeout: toolsStartupTimeout,
 		TrialMode:           c.trialMode,
 		TrialLogicalRepo:    c.trialLogicalRepoSlug,
-		GitHubToken:         extractStringValue(result.Frontmatter, "github-token"),
+		GitHubToken:         extractStringFromMap(result.Frontmatter, "github-token", nil),
 		StrictMode:          c.strictMode,
 		SecretMasking:       secretMasking,
 	}

pkg/workflow/config_helpers.go

@@ -30,12 +30,15 @@ func parseLabelsFromConfig(configMap map[string]any) []string {
 	return nil
 }
 
-// parseStringFromConfig is a generic helper that extracts and validates a string value from a config map
+// extractStringFromMap is a generic helper that extracts and validates a string value from a map
 // Returns the string value, or empty string if not present or invalid
-func parseStringFromConfig(configMap map[string]any, key string) string {
-	if value, exists := configMap[key]; exists {
+// If log is provided, it will log the extracted value for debugging
+func extractStringFromMap(m map[string]any, key string, log *logger.Logger) string {
+	if value, exists := m[key]; exists {
 		if valueStr, ok := value.(string); ok {
-			configHelpersLog.Printf("Parsed %s from config: %s", key, valueStr)
+			if log != nil {
+				log.Printf("Parsed %s from config: %s", key, valueStr)
+			}
 			return valueStr
 		}
 	}
@@ -45,13 +48,13 @@ func parseStringFromConfig(configMap map[string]any, key string) string {
 // parseTitlePrefixFromConfig extracts and validates title-prefix from a config map
 // Returns the title prefix string, or empty string if not present or invalid
 func parseTitlePrefixFromConfig(configMap map[string]any) string {
-	return parseStringFromConfig(configMap, "title-prefix")
+	return extractStringFromMap(configMap, "title-prefix", configHelpersLog)
 }
 
 // parseTargetRepoFromConfig extracts the target-repo value from a config map.
 // Returns the target repository slug as a string, or empty string if not present or invalid.
 // This function does not perform any special handling or validation for wildcard values ("*");
 // callers are responsible for validating the returned value as needed.
 func parseTargetRepoFromConfig(configMap map[string]any) string {
-	return parseStringFromConfig(configMap, "target-repo")
+	return extractStringFromMap(configMap, "target-repo", configHelpersLog)
 }

pkg/workflow/config_parsing_helpers_test.go

@@ -4,7 +4,7 @@ import (
 	"testing"
 )
 
-func TestParseStringFromConfig(t *testing.T) {
+func TestExtractStringFromMap(t *testing.T) {
 	tests := []struct {
 		name     string
 		input    map[string]any
@@ -78,7 +78,7 @@ func TestParseStringFromConfig(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := parseStringFromConfig(tt.input, tt.key)
+			result := extractStringFromMap(tt.input, tt.key, nil)
 			if result != tt.expected {
 				t.Errorf("expected %q, got %q", tt.expected, result)
 			}

pkg/workflow/frontmatter_helpers.go

@@ -1,19 +1,5 @@
 package workflow
 
-// extractStringValue extracts a string value from the frontmatter map
-func extractStringValue(frontmatter map[string]any, key string) string {
-	value, exists := frontmatter[key]
-	if !exists {
-		return ""
-	}
-
-	if strValue, ok := value.(string); ok {
-		return strValue
-	}
-
-	return ""
-}
-
 // parseIntValue safely parses various numeric types to int
 // This is a common utility used across multiple parsing functions
 func parseIntValue(value any) (int, bool) {