Skip to content

Commit 9b3594e

Browse files
authored
Contribution Check: require issue_number passthrough for add_comment safe outputs (#35347)
1 parent 4a2b579 commit 9b3594e

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.github/workflows/contribution-check.lock.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/contribution-check.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,11 @@ Gather all returned JSON objects. If a subagent call fails, record the PR with v
179179

180180
### Posting comments
181181

182-
Use the `comment-dispatcher` agent on the verdict array (the JSON objects returned by the contribution-checker subagent in Step 1) to get the list of comments to post. For each returned entry, emit one `add_comment` safe output using `issue_number` and `body` (do not specify the repo — `target-repo` is pre-configured).
182+
Use the `comment-dispatcher` agent on the verdict array (the JSON objects returned by the contribution-checker subagent in Step 1) to get the list of comments to post.
183+
184+
For each returned `{issue_number, body}` payload, emit one `add_comment` safe output that includes **both fields verbatim**`issue_number` is required.
185+
The safe-output validator rejects `add_comment` items that omit `item_number` / `issue_number` / `pull_request_number` (for example: `Target is "*" but no item_number/...`) and fails the entire `safe_outputs` job.
186+
Do not specify the repo — `target-repo` is pre-configured.
183187

184188
## Completion Gate
185189

0 commit comments

Comments
 (0)