Remove legacy upload-assets handling from JavaScript

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

pkg/workflow/js/upload_assets.cjs

@@ -76,25 +76,17 @@ async function main() {
     return;
   }
 
-  // Find all upload-asset items (singular is the standard)
+  // Find all upload-asset items
   const uploadItems = result.items.filter(/** @param {any} item */ item => item.type === "upload_asset");
 
-  // Handle legacy upload-assets (plural, hyphenated) with warning
-  const legacyUploadAssetsItems = result.items.filter(/** @param {any} item */ item => item.type === "upload-assets");
-  if (legacyUploadAssetsItems.length > 0) {
-    core.warning(`Found ${legacyUploadAssetsItems.length} item(s) with legacy type "upload-assets" (plural). This type is deprecated. Use "upload_asset" (singular) instead.`);
-  }
-
-  const allUploadItems = [...uploadItems, ...legacyUploadAssetsItems];
-
-  if (allUploadItems.length === 0) {
+  if (uploadItems.length === 0) {
     core.info("No upload-asset items found in agent output");
     core.setOutput("upload_count", "0");
     core.setOutput("branch_name", normalizedBranchName);
     return;
   }
 
-  core.info(`Found ${allUploadItems.length} upload-asset item(s)`);
+  core.info(`Found ${uploadItems.length} upload-asset item(s)`);
 
   let uploadCount = 0;
   let hasChanges = false;
@@ -124,7 +116,7 @@ async function main() {
     }
 
     // Process each asset
-    for (const asset of allUploadItems) {
+    for (const asset of uploadItems) {
       try {
         const { fileName, sha, size, targetFileName } = asset;
 
@@ -182,7 +174,7 @@ async function main() {
         core.info(`Successfully uploaded ${uploadCount} assets to branch ${normalizedBranchName}`);
       }
 
-      for (const asset of allUploadItems) {
+      for (const asset of uploadItems) {
         if (asset.fileName && asset.sha && asset.size && asset.url) {
           core.summary.addRaw(`- [\`${asset.fileName}\`](${asset.url}) → \`${asset.targetFileName}\` (${asset.size} bytes)`);
         }

pkg/workflow/js/upload_assets.test.cjs

@@ -62,25 +62,6 @@ const mockCore = { debug: vi.fn(), info: vi.fn(), notice: vi.fn(), warning: vi.f
           (expect(branchNameCall).toBeDefined(), expect(branchNameCall[1]).toBe("assets/my-branch"));
         });
       }),
-      describe("legacy upload-assets type handling", () => {
-        it("should warn about legacy upload-assets type (plural hyphenated)", async () => {
-          ((process.env.GH_AW_ASSETS_BRANCH = "assets/test-workflow"), (process.env.GH_AW_SAFE_OUTPUTS_STAGED = "false"));
-          const assetDir = "/tmp/gh-aw/safeoutputs/assets";
-          fs.existsSync(assetDir) || fs.mkdirSync(assetDir, { recursive: !0 });
-          const assetPath = path.join(assetDir, "test.png");
-          fs.writeFileSync(assetPath, "fake png data");
-          const crypto = require("crypto"),
-            fileContent = fs.readFileSync(assetPath),
-            agentOutput = {
-              items: [{ type: "upload-assets", fileName: "test.png", sha: crypto.createHash("sha256").update(fileContent).digest("hex"), size: fileContent.length, targetFileName: "test.png", url: "https://example.com/test.png" }],
-            };
-          setAgentOutput(agentOutput);
-          (mockExec.exec.mockImplementation(async () => 0), await executeScript());
-          const warningCalls = mockCore.warning.mock.calls.filter(call => call[0].includes("legacy type"));
-          (expect(warningCalls.length).toBeGreaterThan(0), expect(warningCalls[0][0]).toContain("upload-assets"), expect(warningCalls[0][0]).toContain("deprecated"));
-          fs.existsSync(assetPath) && fs.unlinkSync(assetPath);
-        });
-      }),
       describe("branch prefix validation", () => {
         (it("should allow creating orphaned branch with 'assets/' prefix when branch doesn't exist", async () => {
           (fs.existsSync("test.png") && fs.unlinkSync("test.png"), (process.env.GH_AW_ASSETS_BRANCH = "assets/test-workflow"), (process.env.GH_AW_SAFE_OUTPUTS_STAGED = "false"));